Consolidate .editorconfig files into one at the repository root - #8457
Merged
Conversation
Replaces 22 identical per-directory .editorconfig files with a single root file. Each of those declared `root = true`, so nothing above them could ever apply, and modules such as rewrite-scala had no coverage at all. Trailing whitespace is not trimmed under test source sets, resources and the JS/Python fixture trees, since this repository's fixtures and golden files carry it deliberately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces 22 identical per-directory
.editorconfigfiles with a single one at the repository root, matching whatrewrite-static-analysisdoes. Every one of those files declaredroot = true, so nothing above them could ever apply, and modules such asrewrite-scalahad no coverage at all; the root file now covers allsrc/testandsrc/integTestJava sources uniformly.Unlike
rewrite-static-analysis, trailing whitespace is not trimmed under test sources, resources and the JS/Python fixture trees — this repository is the parser and formatter, so trailing whitespace is often the thing under test (AutoFormatTest.javaalone has 257 lines ending in whitespace, and goldens such asMETA-INF/rewrite/recipes.csvand the gradle-wrapper checksums carry it deliberately).rewrite-java-tckkeeps its existing file in place, since it ships its tests fromsrc/main; it only dropsroot = trueso the root settings reach it.Every rule was verified with the
editorconfigcore CLI against representative files in each category.