Preserve imported BOM precedence in SortDependencies

[martinfrancois]

Suggested review order: 1 of 52 (Score: 10)
Review first: None - this is the first item in the queue.

What's changed?

Preserves the positions of imported BOM dependencies when SortDependencies sorts Maven dependencies. Other dependencies still sort around those fixed positions, and comments remain attached to their original dependency.

What's your motivation?

Recipe: org.openrewrite.maven.SortDependencies.

I found this by running org.openrewrite.maven.SortDependencies from org.openrewrite:rewrite-maven:8.87.0 on pom.xml in Symphony-Trello at a8013f27. I reproduced the same result on that exact checkout with the latest released recipe artifact, org.openrewrite:rewrite-maven:8.90.0, using org.openrewrite.maven:rewrite-maven-plugin:6.46.1.

Before

<!-- Keep the stable OpenTelemetry modules aligned while the Quarkus BOM trails the security fix. -->
<dependency>
  <groupId>io.opentelemetry</groupId>
  <artifactId>opentelemetry-bom</artifactId>
</dependency>
<dependency>
  <groupId>${quarkus.platform.group-id}</groupId>
  <artifactId>${quarkus.platform.artifact-id}</artifactId>
</dependency>

Actual after the recipe

<dependency>
  <groupId>${quarkus.platform.group-id}</groupId>
  <artifactId>${quarkus.platform.artifact-id}</artifactId>
</dependency>
<!-- Keep the stable OpenTelemetry modules aligned while the Quarkus BOM trails the security fix. -->
<dependency>
  <groupId>io.opentelemetry</groupId>
  <artifactId>opentelemetry-bom</artifactId>
</dependency>

Expected after the recipe

(unchanged)

Imported BOM order controls dependency-management precedence. Sorting these two entries changes which managed version wins, so the recipe changes project behavior rather than presentation alone.

Confirmed real-world execution

• Project: Symphony-Trello.
• Location: pom.xml at a8013f27.
• Discovery checkout: martinfrancois/symphony-trello@a8013f27.

Anything in particular you'd like reviewers to focus on?

Please review the fixed-position treatment of imported BOMs and the conservative handling of property placeholders. A placeholder in a BOM marker remains fixed because profile-local properties are not always present in the effective model used during the visit.

Have you considered any alternatives or workarounds?

Reapplying the intended BOM order after every recipe run is fragile and makes the recipe non-idempotent for this project.

Any additional context

Pre-existing tests changed: None.

• Target commit: martinfrancois/symphony-trello@a8013f27
• Discovery release: org.openrewrite:rewrite-maven:8.87.0
• Latest verification release: org.openrewrite:rewrite-maven:8.90.0
• Focused test: SortDependenciesTest.doesNotReorderImportedBomsWithSemanticPrecedence
• Upstream reproduction commit: openrewrite/rewrite@63428228

This change was prepared with AI assistance. I reviewed the target execution evidence, implementation, tests, generated metadata, and contribution text.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've run ./gradlew build locally, and committed any resulting changes to recipes.csv
• I've formatted the lines I changed, without reformatting code I didn't touch