fix return code handling in stashcp#100
Merged
djw8605 merged 1 commit intoopensciencegrid:masterfrom Jul 25, 2019
Merged
Conversation
doStashCpSingle() was inconsistent in whether its return value indicated error or success. The messed up return code worked its way down to the exit status for the script. I'm fixing this by making doStashCpSingle & dostashcpdirectory just return the error status - 0 for success, 1 for failure
djw8605
approved these changes
Jul 25, 2019
Member
|
I'll wait for ci to come back and merge it. |
Member
|
CI failed for unrelated reasons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doStashCpSingle()was inconsistent in whether its return value indicated error or success. The messed up return code worked its way down to the exit status for the script.I'm fixing this by making
doStashCpSingle&dostashcpdirectoryjust return the error status -0for success,1for failure.