Python 3.6 support for stashcp#115
Merged
djw8605 merged 7 commits intoopensciencegrid:masterfrom Jul 8, 2020
Merged
Conversation
Member
|
Could you also add Python 3 to the .travis.yml test matrix, otherwise, this looks good. (though, a lot of the tests happen within a docker container) |
Member
|
What's up with the revert? |
Contributor
Author
|
That commit doesn't actually do anything useful -- it adds python 3.6 to the build matrix outside docker but has no effect on what runs inside the docker images. I'll squash/drop those once I have something working. |
Contributor
Author
|
I fixed the CI so there are a couple new test runs that use Python 3 instead of 2. @djw8605 , can you take a look? |
djw8605
approved these changes
Jul 8, 2020
Member
djw8605
left a comment
djw8605
left a comment
There was a problem hiding this comment.
All these changes look good. I'm more than happy to support python3! Thanks for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syntax fixes, standard library rearrangement, and string handling. Tested on a local CentOS 8 VM and a Fermicloud SLF 7 VM.