Skip to content

Refactoring es_send to be a function #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bbockelm merged 3 commits into from
Dec 6, 2016
Merged

Refactoring es_send to be a function #31

bbockelm merged 3 commits into from
Dec 6, 2016

Conversation

@djw8605
Copy link
Member

@djw8605 djw8605 commented Dec 6, 2016

Fixes #19

@djw8605
Copy link
Member Author

djw8605 commented Dec 6, 2016

@bbockelm Ok, this pull request satisfies everything in #19. It's still not great, but there's just a lot of metrics to send to ES.

bbockelm
bbockelm approved these changes Dec 6, 2016
View reviewed changes
Copy link
Contributor

@bbockelm bbockelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough start - we can always return at a later date to clean up more.

@bbockelm bbockelm merged commit ddd398c into opensciencegrid:develop Dec 6, 2016
@djw8605 djw8605 mentioned this pull request Dec 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbockelm bbockelm bbockelm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djw8605 @bbockelm