Skip to content

Make file size query failure not fatal#87

Merged
matyasselmeci merged 3 commits intoopensciencegrid:masterfrom
matyasselmeci:wip/filesize
Oct 26, 2018
Merged

Make file size query failure not fatal#87
matyasselmeci merged 3 commits intoopensciencegrid:masterfrom
matyasselmeci:wip/filesize

Conversation

@matyasselmeci
Copy link
Copy Markdown
Contributor

Don't make it be an error if we fail to find the size of the file by querying the origin.

@matyasselmeci matyasselmeci requested a review from djw8605 October 24, 2018 22:12
@djw8605
Copy link
Copy Markdown
Member

djw8605 commented Oct 25, 2018

Could you set filesize in the payload to the size of the dowloaded file if filesize isn't in the payload object?

@matyasselmeci
Copy link
Copy Markdown
Contributor Author

Sure.

@djw8605
Copy link
Copy Markdown
Member

djw8605 commented Oct 26, 2018

@matyasselmeci can you merge in master, then merge this PR.

@matyasselmeci matyasselmeci merged commit 4cf6fcc into opensciencegrid:master Oct 26, 2018
@matyasselmeci matyasselmeci deleted the wip/filesize branch October 26, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants