Adding initial http support when xrd not available#94
Adding initial http support when xrd not available#94matyasselmeci merged 13 commits intoopensciencegrid:masterfrom
Conversation
|
|
||
| # Append port 8000, which is just a convention for now, not set in stone | ||
| cache += ":8000" | ||
| curl_command = "cd %s; curl %s -L --connect-timeout 30 --speed-limit 1024 %s --fail %s%s" % (dest_dir, output_mode, download_output, cache, source) |
There was a problem hiding this comment.
This is totally gonna break if dest_dir has a space in it. I suggest quoting it -- either with re.quote() or pipes.quote().
|
Can you add a command-line argument to force HTTP? That would be useful for testing. |
|
I like this! Let me do some testing... |
|
Can you print a human-readable success/failure message instead of JSON? |
|
Shoot, it wasn't suppose to print anything. That was a debug line that snuck in. If it fails, it should print something. But if it's successful, it should be completely quiet, like |
|
Sure, sounds good. |
I'm seeing this message but the operation was successful so the |
|
also, why isn't it getting cached? That was not the first time I ran that same command on that same host... |
|
I made the non-debug messages more quiet. stashcp itself doesn't cache anything, it relies on cache it connects to to cache the data. |
Adding http, and the tests for it, for when xrootd is not available.
There was a lot of work to make
curlbehave likecp