Skip to content

Post processing#49

Open
mzecc wants to merge 45 commits intoopenscm:mainfrom
mzecc:post_processing
Open

Post processing#49
mzecc wants to merge 45 commits intoopenscm:mainfrom
mzecc:post_processing

Conversation

@mzecc
Copy link
Copy Markdown
Collaborator

@mzecc mzecc commented Mar 24, 2026

Description

Added post-processing in line with the CMIP7 ScenarioMIP workflow.

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@mzecc
Copy link
Copy Markdown
Collaborator Author

mzecc commented Mar 27, 2026

I leave a question here @znichollscr . I built some tests for the post-processing and they seem to work fine. Now I was trying to build a test that runs the whole cmip7-scenariomip pipeline. In doing this I realised that it is not possible to obtain the same results we delivered in scenarioMIP (correct?). There we are infilling the aggregated regional harmonised gases and in the current state of gcages we deal with global stuff only. So what should I do? Should I make a run in emission_harmonisation_historical with the global harmonised values to be able to create some tests?

@znichollscr
Copy link
Copy Markdown
Collaborator

In doing this I realised that it is not possible to obtain the same results we delivered in scenarioMIP (correct?). There we are infilling the aggregated regional harmonised gases and in the current state of gcages we deal with global stuff only

Correct

Should I make a run in emission_harmonisation_historical with the global harmonised values to be able to create some tests?

Yep.

Option b, which isn't a bad one so up to you which you prefer: we've tested all the individual pieces. Therefore, all we're really doing by plumbing them altogether is just checking that the plumbing works. So, we could instead do a test where we just run the pipeline once and use https://pytest-regressions.readthedocs.io/en/latest to save the output. Then we just assume that this output is correct (because we've tested all the individual pieces), but now we have a test that a) makes sure all the pieces work together and b) ensures that, if we break anything in the pipeline in future, we'll get notified about it.

@mzecc
Copy link
Copy Markdown
Collaborator Author

mzecc commented Apr 17, 2026

Should we merge this one?

@znichollscr
Copy link
Copy Markdown
Collaborator

You'll need to fix up the merge conflicts now that we merged #52.

Also what is your thought about this comment? #49 (comment)

But yes, overall happy to merge if you need this in quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants