Skip to content

climate-processor workflow (AR6)#52

Merged
znichollscr merged 28 commits intoopenscm:mainfrom
mzecc:climate_processor_ar6
Apr 18, 2026
Merged

climate-processor workflow (AR6)#52
znichollscr merged 28 commits intoopenscm:mainfrom
mzecc:climate_processor_ar6

Conversation

@mzecc
Copy link
Copy Markdown
Collaborator

@mzecc mzecc commented Apr 14, 2026

Description

In the process for porting the AR6 workflow into climate processor have been added:

  1. Calculations of greenhouse gas aggregate timeseries;
  2. Key steps for working with MAGICC can be more easily re-used

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@mzecc mzecc requested a review from znichollscr April 14, 2026 12:30
Copy link
Copy Markdown
Collaborator

@znichollscr znichollscr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, definitely getting there. A bit of clean up to do. Again, we can either do that, then merge everything, or we can merge first, then go straight to getting the ScenarioMIP workflow into gcages, then clean up after. Depends on how much time pressure is on you

Comment thread src/gcages/ar6/climate_processor_ar6.py Outdated
Comment thread src/gcages/ar6/climate_processor_ar6.py Outdated
Comment thread src/gcages/ar6/climate_processor_ar6.py Outdated
Comment thread src/gcages/ar6/climate_processor_ar6.py Outdated
Comment thread src/gcages/ar6/climate_processor_ar6.py Outdated
Comment thread src/gcages/ar6/climate_processor_ar6.py Outdated
Comment thread src/gcages/ar6/climate_processor_ar6.py Outdated
Comment thread src/gcages/ar6/climate_processor_ar6.py Outdated
Comment thread src/gcages/ar6/climate_processor_ar6.py Outdated
Comment thread src/gcages/ar6/climate_processor_ar6.py Outdated
@mzecc
Copy link
Copy Markdown
Collaborator Author

mzecc commented Apr 15, 2026

I must be doing something wrong with the MAGICC configuration. The scm output gives different values from what the original climate-processor gives.

@znicholls
Copy link
Copy Markdown
Contributor

I must be doing something wrong with the MAGICC configuration. The scm output gives different values from what the original climate-processor gives.

What command/test are you running that shows you that you're getting different output? I assume that is in the climate-processor repository, so can you please make a pull request into that repository and post the test command that you're running there

@mzecc
Copy link
Copy Markdown
Collaborator Author

mzecc commented Apr 16, 2026

can you please make a pull request into that repository and post the test command that you're running there

Done, requested your review to the znicholls account.

@znicholls
Copy link
Copy Markdown
Contributor

Finished off in mzecc#8

@mzecc
Copy link
Copy Markdown
Collaborator Author

mzecc commented Apr 17, 2026

Good to merge?

@znichollscr
Copy link
Copy Markdown
Collaborator

Yep

@znichollscr znichollscr merged commit 8c0275e into openscm:main Apr 18, 2026
21 checks passed
@znichollscr znichollscr mentioned this pull request Apr 18, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants