Add Dockerfile, splitByBook, and and fix invalid JSON#73
Merged
jdejoode merged 1 commit intoopenscriptures:masterfrom Dec 13, 2021
davidbetz:MODERNIZE_AND_CONTAINERIZE
Merged
Add Dockerfile, splitByBook, and and fix invalid JSON#73jdejoode merged 1 commit intoopenscriptures:masterfrom davidbetz:MODERNIZE_AND_CONTAINERIZE
jdejoode merged 1 commit intoopenscriptures:masterfrom
davidbetz:MODERNIZE_AND_CONTAINERIZE
Conversation
Contributor
davidbetz
commented
Aug 15, 2020
davidbetz
commented
- Added Dockerfile
- Added splitByBook
- Made output cross-platform (e.g. not a Node module)
- Fixed invalid JSON (string manipulation of JSON/XML/YAML is always bad; and JSON uses double-quotes)
jdejoode
approved these changes
Dec 13, 2021
Contributor
jdejoode
left a comment
jdejoode
left a comment
There was a problem hiding this comment.
The docker container is a good addition to the project. The revisions to the python code are helpful. Great work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.