CONUS Site Data Provider - #228
Conversation
… generic failure to read.
…load data if found in a gridded region
…location on the grid.
There was a problem hiding this comment.
Two things so far:
- Why take in minLat, maxLat, minLon, maxLon, then build a region from it for getApplicableRegion()? Why not just take in the region in the constructor and return that? Is there a reason to convert the original region into a rectangular one defined by the extrema?
- I'm not yet seeing the benefit of loading the GeoJSON to
GriddedRegion's overRegion's, aren't you just using them for Region.contains(Location) which isn't specific to a GriddedRegion?
There was a problem hiding this comment.
Done. Now uses applicableRegion directly.
There was a problem hiding this comment.
You'll also need to add the mapping in setParameterValue(Parameter, Collection<SiteDataValue<?>>) to do the actual parameter translation.
There was a problem hiding this comment.
Done. Confirmed Zsed available via SiteDataCombinedApp.
There was a problem hiding this comment.
Please change the default store dir from ~/.site_data to ~/.opensha/site_data, since we already use ~/.opensha to store other cached data.
|
I cannot get this to successfully download, have you run into any similar issues? I'm running the main method of This many times: ...and this once after a long pause: Meanwhile, I can download the file fine in browser or via wget without error, which works robustly while the Java downloader is failing every time. It's not just bad timing, I keep trying both in java and outside of java and the behavior is consistent. |
…of coordiante extrema.
… the Accept header explicitly.
Fixed. I couldn't replicate the issue on macOS, but I tried on Expanse and found the 406 bug. I explicitly add client headers to Accept / and follow redirects with copied headers and it works now using OpenJDK 17. |
…sediment-depth-data-retrieval
kevinmilner
left a comment
There was a problem hiding this comment.
Looks good, and no issues downloading now!
This PR adds support for USGS basin and sediment depth data (#205) via a new Site Data Provider retrieving NSHM18 and NSHM23 site data for the Conterminous U.S.
The data is retrieved from the USGS GitLab and doesn't use servlets (e.g., like with the
AbstractBinarySiteDataLoader)Overview
VersionResolverusing a URL provided by concrete implementationsAbstractGitLabDownloaderto download CONUS site data if not already downloadedAbstractGitLabDownloaderand then loads the Regions and site data mapping into memoryAbstractGriddedSiteDataLoaderto load data with aCONUS_Downloader, defines the applicable region for the provider, and provides adjustable parameters for selecting the hazard model.Integration
SiteDatatype for Sediment thickness (Zsed) and created an entry in theSiteTranslatorto map to the existing Sediment Thickness parameterCONUS_SiteDataProviderin theOrderedSiteDataProviderListfor retrieval of Z1.0, Z2.5, and Zsed.CONUS_Downloadermanually with a CLT main function.