chore(scanner): add placeholder for storage Account HTTPS enforcement… - #242
chore(scanner): add placeholder for storage Account HTTPS enforcement…#242Ablaze005 wants to merge 4 commits into
Conversation
… rule (AZ-STORAGE-HTTPS-001)
… rule (AZ-STORAGE-HTTPS-001) Signed-off-by: Ablaze005 <ablaze123pariyar@gmail.com>
…m/Ablaze005/openshield into feature/storage-https-enforcement
|
@Ablaze005 currently the git diff shows 1 file create but zero lines of code, so please re review it and also for the new rules follow the codebase exsisting pattern to keep the consistency |
|
sorry about that I identified the mistake in my previous commit, corrected
it, and have now pushed all the required code and test files to this
branch. The PR is fully updated and ready for review.
…On Mon, 10 Aug 2026 at 10:24, Ritik Sah ***@***.***> wrote:
*ritiksah141* left a comment (openshield-org/openshield#242)
<#242 (comment)>
@Ablaze005 <https://github.com/Ablaze005> currently the git diff shows 1
file create but zero lines of code, so please re review it and also for the
new rules follow the codebase exsisting pattern to keep the consistency
—
Reply to this email directly, view it on GitHub
<#242?email_source=notifications&email_token=BO4HM6TLZTXAOL7E3ZHNVRD5JGIGDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMRTHAZTCMRTHE3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5238312396>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BO4HM6U2ZG3ZLR6ACGEJIMD5JGIGDAVCNFSNUABGKJSXA33TNF2G64TZHMYTEMRQHEYDKOBQGI5US43TOVSTWNJQHE4TQNJZGAYTFILWAI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Ablaze005, the rule you have added doesn't follow the rules pattern used elsewhere, no framework mapping, the syntax, rule conventions. The rules own playbook is missing and many things missing. So, before updating the PR I would suggest to go through the codebase understand the syntax, writing style and strucutre, and then re write the whole after that provide the evidence if the rule you trying to add is being tested instead of just adding the seperate test file as we have not approched the method of each-rules/each-test files as you can see the test files under the openshield/tests - tests are being categorized under its category only there is one wxception for the az_pqc rule and lastly provide the testing validation in the PR as well and add NOTE section to look for the review to make it more conivenence |
New Rule: Enforce HTTPS‑Only for Azure Storage Accounts
This PR adds a new rule:
Rule ID: AZ-STORAGE-HTTPS-001
Category: Storage
Severity: HIGH
Purpose: Detect Storage Accounts that do not enforce HTTPS‑only traffic.
Included
-New rule file: az_stor_006.py
-Full scan logic using the new rule architecture (no AzureClient dependency)
-Unit tests:
1)test_storage_https_disabled
2)test_storage_https_enabled
Why this rule matters
Storage Accounts that allow HTTP traffic expose data to interception and downgrade attacks.
This rule helps enforce secure transport requirements.
Testing
All tests pass:
..
Ran 2 tests in 0.00s
OK
DCO Sign‑off
Signed-off-by: Ablaze Pariyarablaze123pariyar@gmail.com
Closes #245