fixes small issue with launching gangway jobs when supporting multiple OpenShift versions#203
Conversation
Move version tag regex match before job file lookup so an explicit version tag takes priority. Skip release image verification during refresh. Remove generated job txt files from tracking and add them to .gitignore. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove sno and tna job txt files from the git index. These are generated at runtime by launch.sh and already covered by the .gitignore rule added in the previous commit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhensel-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
WalkthroughRemoves all nightly-4.22 periodic CI job entries from ChangesOCP RC Job Cleanup and Script Fixes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 9 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/edge-ocp-rc/scripts/launch.sh`:
- Line 148: The launch condition in launch.sh uses REFRESH as an unquoted
command-style boolean, which violates the shell quoting guideline and can fail
shellcheck validation. Update the conditional around the RELEASE_IMAGE check to
use an explicit quoted test for REFRESH in the relevant launch logic, keeping
the behavior the same while ensuring all variable references in the shell script
are quoted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 7cf9fbd0-dfd3-409d-bbe1-bc105a165a6d
📒 Files selected for processing (9)
.gitignoreplugins/edge-ocp-rc/jobs/sno-z-stream.txtplugins/edge-ocp-rc/jobs/sno.txtplugins/edge-ocp-rc/jobs/tna-y-stream.txtplugins/edge-ocp-rc/jobs/tna-z-stream.txtplugins/edge-ocp-rc/jobs/tna.txtplugins/edge-ocp-rc/jobs/tnf-z-stream.txtplugins/edge-ocp-rc/jobs/tnf.txtplugins/edge-ocp-rc/scripts/launch.sh
💤 Files with no reviewable changes (7)
- plugins/edge-ocp-rc/jobs/sno-z-stream.txt
- plugins/edge-ocp-rc/jobs/tnf-z-stream.txt
- plugins/edge-ocp-rc/jobs/tnf.txt
- plugins/edge-ocp-rc/jobs/tna-y-stream.txt
- plugins/edge-ocp-rc/jobs/tna-z-stream.txt
- plugins/edge-ocp-rc/jobs/tna.txt
- plugins/edge-ocp-rc/jobs/sno.txt
| fi | ||
|
|
||
| if [[ -n "$RELEASE_IMAGE" ]]; then | ||
| if [[ -n "$RELEASE_IMAGE" ]] && ! $REFRESH; then |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Quote REFRESH in the condition (severity: medium).
Line 148 uses ! $REFRESH, which leaves the variable unquoted and relies on command-style boolean evaluation. Prefer an explicit quoted comparison.
Suggested fix
-if [[ -n "$RELEASE_IMAGE" ]] && ! $REFRESH; then
+if [[ -n "$RELEASE_IMAGE" && "$REFRESH" != true ]]; thenAs per coding guidelines: **/*.sh requires “Quote all variables in shell scripts” and “Shell scripts must pass shellcheck validation”; and per path instructions/CONTRIBUTING.md, Bash scripts must quote all variables.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if [[ -n "$RELEASE_IMAGE" ]] && ! $REFRESH; then | |
| if [[ -n "$RELEASE_IMAGE" && "$REFRESH" != true ]]; then |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/edge-ocp-rc/scripts/launch.sh` at line 148, The launch condition in
launch.sh uses REFRESH as an unquoted command-style boolean, which violates the
shell quoting guideline and can fail shellcheck validation. Update the
conditional around the RELEASE_IMAGE check to use an explicit quoted test for
REFRESH in the relevant launch logic, keeping the behavior the same while
ensuring all variable references in the shell script are quoted.
Sources: Coding guidelines, Path instructions
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
2 participants
Summary
Details
The job files (tnf.txt, sno.txt, tna.txt and their z/y-stream variants) are generated at runtime by launch.sh and should not be tracked in the repository. They have been removed from the git index but remain on disk.
Summary by CodeRabbit
Bug Fixes
Chores