Skip to content

Specify valid conditions for authorized-request label application#522

Merged
komish merged 1 commit into
openshift-helm-charts:mainfrom
komish:specify-valid-job-outcomes
Jun 2, 2026
Merged

Specify valid conditions for authorized-request label application#522
komish merged 1 commit into
openshift-helm-charts:mainfrom
komish:specify-valid-job-outcomes

Conversation

@komish

@komish komish commented Jun 2, 2026

Copy link
Copy Markdown
Member

The authorized-request label would be applied to PRs in cases where the chart-verifier job would not complete due to some transient error. Actual user verification is delegated to a script, but we can also prevent this label from being applied by being more specific in what job outcomes matter to us (done here by ensuring that the outcome is either success or failure, and not allowing an empty value.

The authorized-request label would be applied to PRs in cases where the
chart-verifier job would not complete due to some transient error.
Actual user verification is delegated to a script, but we can also
prevent this label from being applied by being more specific in what job
outcomes matter to us

Signed-off-by: Jose R. Gonzalez <komish@flutes.dev>
@komish komish requested a review from mgoerens June 2, 2026 19:07
This was referenced Jun 2, 2026
@mgoerens

mgoerens commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

If I understand correctly, needs.chart-verifier.outputs.run-verifier-outcome could be empty thus passing the != failure test.

/lgtm

@komish komish merged commit 01c1801 into openshift-helm-charts:main Jun 2, 2026
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants