Update module github.com/google/cel-go to v0.30.0 - #240
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe indirect Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
go.mod (1)
72-72: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd focused CEL compatibility coverage.
Cover nested
resource/condition()access, defaulttimestamp(ref_time)comparisons, and expression-size limits. Do not treat non-RFC3339 values asEvaluateinputs; JSON decoding rejects them before evaluation. Concurrent evaluation is outside the current sequential Sentinel call path.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` at line 72, Add focused CEL compatibility tests for the dependency version declared near github.com/google/cel-go, covering nested resource/condition() access, default timestamp(ref_time) comparisons, and expression-size limits. Keep inputs RFC3339-valid because JSON decoding occurs before Evaluate, and omit concurrent-evaluation coverage since the Sentinel call path is sequential.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@go.mod`:
- Line 72: Add focused CEL compatibility tests for the dependency version
declared near github.com/google/cel-go, covering nested resource/condition()
access, default timestamp(ref_time) comparisons, and expression-size limits.
Keep inputs RFC3339-valid because JSON decoding occurs before Evaluate, and omit
concurrent-evaluation coverage since the Sentinel call path is sequential.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 40d0cf5a-b569-435c-a02a-dfc250460eb5
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum,!**/go.sum
📒 Files selected for processing (1)
go.mod
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift-hyperfleet/architecture(manual)openshift-hyperfleet/hyperfleet-api(manual) → reviewed against open PR#314konflux/mintmaker/main/go-module-minorpatch-updatesinstead of the default branchopenshift-hyperfleet/hyperfleet-sentinel(manual)openshift-hyperfleet/hyperfleet-adapter(manual) → reviewed against branchkonflux/mintmaker/main/go-module-minorpatch-updatesinstead of the default branchopenshift-hyperfleet/hyperfleet-broker(manual)
Risk Score: 0 —
|
| Signal | Detail | Points |
|---|---|---|
| PR size | 6 lines | +0 |
| Sensitive paths | none | +0 |
Computed by hyperfleet-risk-scorer
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
250ea4b to
1ab68b4
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rafabene The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains the following updates:
v0.29.2→v0.30.0Release Notes
google/cel-go (github.com/google/cel-go)
v0.30.0Compare Source
What's Changed
x in [x]for NaN values by @pranit0808 in cel-expr#1374New Contributors
Full Changelog: cel-expr/cel-go@v0.29.2...v0.29.3
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.