[release-v1.15] Use signed artifacts in cli image #538
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - GO_RUNTIME=registry.access.redhat.com/ubi8/ubi-minimal | ||
| - JAVA_BUILDER=registry.access.redhat.com/ubi8/openjdk-21 | ||
| - JAVA_RUNTIME=registry.access.redhat.com/ubi8/openjdk-21-runtime | ||
| - CLI_ARTIFACTS=brew.registry.redhat.io/rh-osbs/openshift-serverless-1-kn-cli-artifacts-rhel8:1.15.0 |
There was a problem hiding this comment.
This is image that is used in Konflux builds. Both pull request and on-push.
| @@ -1,10 +1,18 @@ | |||
| # This is not generated Dockerfile, yet! | |||
| ARG GO_RUNTIME=registry.access.redhat.com/ubi8/ubi-minimal | |||
| ARG CLI_ARTIFACTS=registry.redhat.io/openshift-serverless-1/kn-cli-artifacts-rhel8:1.14 | |||
There was a problem hiding this comment.
We use public image here as a placeholder for openshift ci builds to pass.
|
|
||
| RUN mkdir -p /usr/share/kn | ||
|
|
||
| COPY --from=builder /usr/share/kn /usr/share/kn |
There was a problem hiding this comment.
Copying from previous stage to prevent label inheritance and related EC failures.
|
/retest |
| - GO_RUNTIME=registry.access.redhat.com/ubi8/ubi-minimal | ||
| - JAVA_BUILDER=registry.access.redhat.com/ubi8/openjdk-21 | ||
| - JAVA_RUNTIME=registry.access.redhat.com/ubi8/openjdk-21-runtime | ||
| - CLI_ARTIFACTS=brew.registry.redhat.io/rh-osbs/openshift-serverless-1-kn-cli-artifacts-rhel8:1.15.0 |
There was a problem hiding this comment.
This will be overridden by konfluxgen. I guess you need to add this here: https://github.com/openshift-knative/hack/blob/main/config/client.yaml as an image override (like here: https://github.com/openshift-knative/hack/blob/4183948d2539a0e8b1cd67d443ace45e65ea248f/config/serverless-operator.yaml#L8-L16)
dsimansk
force-pushed
the
pr/signed-binaries
branch
from
39aa5b5 to
bbd3ff0
Compare
|
/override ? |
|
@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / kn-client-cli-artifacts-115" |
|
@dsimansk: Overrode contexts on behalf of dsimansk: Red Hat Konflux / serverless-operator-135-enterprise-contract / kn-client-cli-artifacts-115, Red Hat Konflux / serverless-operator-135-enterprise-contract / kn-client-kn-115, Red Hat Konflux / serverless-operator-135-enterprise-contract / kn-client-test-grpc-ping-115, Red Hat Konflux / serverless-operator-135-enterprise-contract / kn-client-test-helloworld-115, Red Hat Konflux / serverless-operator-135-enterprise-contract / kn-client-test-servingcontainer-115, Red Hat Konflux / serverless-operator-135-enterprise-contract / kn-client-test-sidecarcontainer-115, Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group pr/signed-binaries DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit f5b5ad7
into
openshift-knative:release-v1.15
2 participants
No description provided.