Skip to content

Conversation

@matzew
Copy link
Member

@matzew matzew commented Feb 13, 2025

No description provided.

matzew and others added 24 commits February 12, 2025 17:18
* Add initial raw API types and controller/reconciler. Levering internally the container source for the handling of the kamelet workloads. the logic for applying the env-vars is a bit verbose, but can be improved.
Tests/lifeccyle and some other improvements are still missing. but this works.

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* adding reflection to make the mapping less verbose, and more flexible to extend...

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add DDB Streams

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* polish and add minimal tests

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update pkg/apis/sources/v1alpha1/integration_lifecycle.go

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* Update pkg/apis/sources/v1alpha1/integration_lifecycle.go

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* Fix compiler warnings

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* use other image coordinates

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* first test for source

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Adding initial rekt test

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Adding SSL support and test for IntegrationSource

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Formatting fixes

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Disable OIDC tests for now

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* use knative nightly images

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Fixing linters

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* addressing comments, Part1

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
💄 add missing copyright boilerplate

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
…ions (knative#8312)

🔑 Use a generic access/secret key in the secret for AWS connections

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
… per containersource/image (knative#8315)

💄 Do not generate SSL env vars for each struct entry, just once per containersource/image

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
…ability (knative#8321)

Update API and use custom tags on structs

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Moving API to a versioned common/integration folder

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
…e#8327)

* create new integration/source folder and factor common code into helper.go

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 💄 improve formatting...

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* fixing import

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
💄 correct comments ...

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
* create new integration/source folder and factor common code into helper.go

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 💄 improve formatting...

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* fixing import

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* First Sink

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Updates on sink

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* starting common types for source

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* starting common types for sink

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* some code share and refactorings

* use other image coordinates

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add missing api and tests for sink and run codegen

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Fixes

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Adding cert

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Adding test

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Rekt test for sink

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Rekt test for sink

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* correct status code

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* More...

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* re-add service

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* delete unversioned common api

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Updates, latest conflicts and formatting
Clean ups
Adding tests for reconciler

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

conflict

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
…ative#8342)

bool annotations for represented as string, to avoid parsing errors

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
* Align IntegrationSink CRD w/ IntegrationSource CRD

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 💄 Remove old job-sink references

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Docs change

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
…keys, for AWS access/secret key vals (knative#8345)

💄 Avoid using twice hardcoded strings for the names of the Kubescret keys, for AWS access/secret key vals

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
🛂 Add integrationsinks-addressable-resolver cluster role

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
…#8355)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
🔥 We changed the event type on the images

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
adding sns sink

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Remove session token and profile credential name

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
💄 We renamed those fields to , and we reflect that now in validation

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
🧹 Remove unused filter function

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Going OIDC for Integration Source:
- Generating OIDC specific evn_vars for Knative client of camel
- Adding rekt-test for OIDC feature of the source

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
…audience to ensure the camel containers work correct (knative#8448)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@openshift-ci openshift-ci bot requested review from aliok and lberk February 13, 2025 12:38
@matzew
Copy link
Member Author

matzew commented Feb 13, 2025


E0213 14:18:30.086626       1 reflector.go:150] knative.dev/pkg/controller/controller.go:726: Failed to watch *v1alpha1.IntegrationSink: failed to list *v1alpha1.IntegrationSink: integrationsinks.sinks.knative.dev is forbidden: User "system:serviceaccount:knative-eventing:eventing-controller" cannot list resource "integrationsinks" in API group "sinks.knative.dev" at the cluster scope
W0213 14:18:30.482104       1 reflector.go:547] knative.dev/pkg/controller/controller.go:726: failed to list *v1alpha1.IntegrationSource: integrationsources.sources.knative.dev is forbidden: User "system:serviceaccount:knative-eventing:eventing-controller" cannot list resource "integrationsources" in API group "sources.knative.dev" at the cluster scope

see:
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift-knative_eventing/1077/pull-ci-openshift-knative-eventing-release-v1.16-417-test-reconciler/1890017682447667200/artifacts/test-reconciler/knative-must-gather/artifacts/gather-knative/quay-io-openshift-knative-must-gather-sha256-f1cd829ea23838ac3e9b7e3a42269ea34a32e7af6a5465f9d5d21a3caf3ce446/knative-eventing/pods/eventing-controller-5f48f7cdb5-blst5.log

@creydr
Copy link
Collaborator

creydr commented Feb 14, 2025

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1e770ef into openshift-knative:release-v1.16 Feb 14, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants