[WIP] Add configurable metric attributes deny list#1895
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest kn-eventing-auth-proxy-121-on-pull-request |
|
@creydr: The Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Vendor knative.dev/pkg changes that add a metrics-attributes-deny config key for filtering high-cardinality metric attributes from all instruments via an OTel View. Add documentation for the new key in config-observability.
Ensures the vendor and configmap changes survive make generate-release.
…OrDie Read the deny list from cfg.Metrics.AttributesDenyList() (provided by knative.dev/pkg) and apply it as an OTel View in eventing's own observability setup path.
|
@creydr: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Vendor knative.dev/pkg changes that add a metrics-attributes-deny config key for filtering high-cardinality metric attributes from all instruments via an OTel View. Add documentation for the new key in config-observability.