[HYPERSHELL-135] feat(db): add deployment-backed gateway databases - #197
Merged
Conversation
Default gateway database placement to dedicated PostgreSQL Deployments while retaining explicit CNPG support. Keep database_id required but server-owned, converge database resources and credentials, and remove dedicated databases when gateways are deleted. HYPERSHELL-135
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainCI follow-up
This branch addresses the failures observed on the earlier fork PR:
database_idin the web-console provisioning request, matching the existing Playwright expectation while allowing the API server to assign the real databaseValidation
make checkcd components/control-plane && go test ./internal/reconciler ./internal/gateway ./internal/watchercd components/api-server && make generate generate-sdk(clean working tree afterward)