fix: remove aws.credentials from mlflow vault definition

[MML-coder]

Summary

• Remove aws.credentials content block from vaults/psap-forge-mlflow-export.yaml
• The cluster secret vault-psap-forge-mlflow-export does not contain this key, causing vault validation to fail and Fournos pipelines to abort at the prepare step

Test plan

• Submitted FournosJob rhaiis-mlflow-full-zmptm with this SHA — prepare step now passes vault validation
• Verify full pipeline completes (test + export-artifacts)

Summary by CodeRabbit

• Bug Fixes
  • Removed an exposed AWS credential entry from the vault configuration, reducing the risk of sensitive information being shared.
  • Preserved the existing MLFlow secret settings and related connection fields.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ashtarkb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8a62da6f-af85-4f75-956f-f6fa4b11d310

📥 Commits

Reviewing files that changed from the base of the PR and between 1ad7915 and ae5dcbb.

📒 Files selected for processing (1)

• vaults/psap-forge-mlflow-export.yaml

💤 Files with no reviewable changes (1)

• vaults/psap-forge-mlflow-export.yaml

---

📝 Walkthrough

Walkthrough

The vault export YAML removes the aws.credentials entry and leaves the MLFlow secret plus censoring fields intact.

Changes

Vault export secret cleanup

Layer / File(s)	Summary
Remove AWS credentials entry vaults/psap-forge-mlflow-export.yaml	The vault config deletes the aws.credentials description and sample credential contents.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• openshift-psap/forge#82: Removes related AWS-credential vault wiring for the same MLFlow export vault and keeps the mlflow-secret.yaml reference.

Poem

I hop through vaults with whiskers bright,
One secret less feels neat tonight.
The MLFlow burrow stays snug and true,
While old AWS crumbs say adieu.
🐇

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: removing aws.credentials from the MLflow vault definition.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kpouget]

good catch, thanks!