Skip to content

OCPBUGS-98101: Use build platform with more disk space#312

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bfournie:large-mem-platform
Jul 8, 2026
Merged

OCPBUGS-98101: Use build platform with more disk space#312
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bfournie:large-mem-platform

Conversation

@bfournie

@bfournie bfournie commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated build pipeline settings for both pull request and push workflows, including switching the build platform from linux-root/amd64 to linux-d320-m8xlarge/amd64 and increasing the pipeline timeout from 4h to 5h.
    • Increased the pull request pipeline execution timeout and adjusted a later task timeout from 3h to 5h.
    • Bumped OCP release parameters to target 4.22.4 (major/minor/patch components) for both workflows.

@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2026
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Walkthrough

Two Tekton PipelineRun definitions were updated. The pull-request PipelineRun now uses a new build platform, updated OCP release values, and longer timeouts. The push PipelineRun now uses a new build platform and updated OCP release values.

Changes

Tekton PipelineRun updates

Layer / File(s) Summary
Pull-request PipelineRun settings
.tekton/ove-ui-iso-pull-request.yaml
Updated the pipeline timeout, build platform, OCP release parameters, and a later task timeout.
Push PipelineRun settings
.tekton/ove-ui-iso-push.yaml
Updated the build platform and OCP release parameters for the push PipelineRun.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only Tekton PipelineRun YAML changed; no Ginkgo test titles were added or edited.
Test Structure And Quality ✅ Passed Only Tekton YAML files changed; no Ginkgo test code was modified, so this test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed PR only changes two Tekton YAML PipelineRuns; no new Ginkgo tests or MicroShift-sensitive APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only Tekton PipelineRun YAML changed; no Ginkgo test files or multi-node assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed The PR only updates Tekton PipelineRun build-platform, release, and timeout params; it adds no node selectors, affinity, spread constraints, replicas, or other topology-sensitive scheduling logic.
Ote Binary Stdout Contract ✅ Passed Only .tekton PipelineRun YAML changed; no Go/test binary code or stdout-producing setup was modified, so no OTE stdout contract issue.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Diff only changes Tekton PipelineRun YAMLs (timeouts/platform/version); no Ginkgo test files or network/IP code added.
No-Weak-Crypto ✅ Passed Diff only changes Tekton timeouts, build-platforms, and release versions; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto/comparison code added.
Container-Privileges ✅ Passed PASS: The diffs only adjust platform/timeouts/release params; no privileged, hostPID/Network/IPC, allowPrivilegeEscalation, or SYS_ADMIN settings were added.
No-Sensitive-Data-In-Logs ✅ Passed Diff only changes timeouts/platform/release params; no new logging, echo/printf, or secret/token/PII-bearing values were added.
Title check ✅ Passed The title matches the main change: switching to a build platform with more disk space.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from pawanpinjarkar and rwsu July 7, 2026 18:42
@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2026
@bfournie

bfournie commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
.tekton/ove-ui-iso-push.yaml (1)

29-30: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Trailing whitespace in build-platforms value.

Same issue as in ove-ui-iso-pull-request.yaml: linux-d160-m4xlarge/amd64 has a trailing space, which risks a platform-name mismatch against the multi-platform-controller's configured host pools.

🐛 Proposed fix
   - name: build-platforms
     value:
-    - linux-d160-m4xlarge/amd64 
+    - linux-d160-m4xlarge/amd64
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.tekton/ove-ui-iso-push.yaml around lines 29 - 30, The build-platforms entry
in the Tekton YAML has a trailing space in the linux-d160-m4xlarge/amd64 value,
which can cause host-pool matching issues. Update the value in the platform list
to remove the extra whitespace and keep it consistent with the other pipeline
config that uses the same platform name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In @.tekton/ove-ui-iso-push.yaml:
- Around line 29-30: The build-platforms entry in the Tekton YAML has a trailing
space in the linux-d160-m4xlarge/amd64 value, which can cause host-pool matching
issues. Update the value in the platform list to remove the extra whitespace and
keep it consistent with the other pipeline config that uses the same platform
name.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cf5394fe-180e-41bb-b3cb-702aa8c803b0

📥 Commits

Reviewing files that changed from the base of the PR and between c52e7a7 and cc1d4e1.

📒 Files selected for processing (2)
  • .tekton/ove-ui-iso-pull-request.yaml
  • .tekton/ove-ui-iso-push.yaml

@bfournie bfournie force-pushed the large-mem-platform branch 3 times, most recently from 548977a to 542e181 Compare July 8, 2026 11:27
@bfournie bfournie force-pushed the large-mem-platform branch from 542e181 to 38e986c Compare July 8, 2026 16:07
@bfournie

bfournie commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/prow/images

@bfournie

bfournie commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

/test images

@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bfournie

bfournie commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

/verified by kflux-prd-rh02/ove-ui-iso-on-pull-request

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 8, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: This PR has been marked as verified by kflux-prd-rh02/ove-ui-iso-on-pull-request.

Details

In response to this:

/verified by kflux-prd-rh02/ove-ui-iso-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie bfournie changed the title NO-JIRA: Use build platform with more disk space OCPBUGS-98101: Use build platform with more disk space Jul 8, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 8, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: This pull request references Jira Issue OCPBUGS-98101, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary by CodeRabbit

  • Chores
  • Updated build pipeline settings for both pull request and push workflows, including switching the build platform from linux-root/amd64 to linux-d320-m8xlarge/amd64 and increasing the pipeline timeout from 4h to 5h.
  • Increased the pull request pipeline execution timeout and adjusted a later task timeout from 3h to 5h.
  • Bumped OCP release parameters to target 4.22.4 (major/minor/patch components) for both workflows.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie

bfournie commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: This pull request references Jira Issue OCPBUGS-98101, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie

bfournie commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2026
@pawanpinjarkar

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit ff33d7c into openshift:main Jul 8, 2026
13 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: Jira Issue Verification Checks: Jira Issue OCPBUGS-98101
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-98101 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary by CodeRabbit

  • Chores
  • Updated build pipeline settings for both pull request and push workflows, including switching the build platform from linux-root/amd64 to linux-d320-m8xlarge/amd64 and increasing the pipeline timeout from 4h to 5h.
  • Increased the pull request pipeline execution timeout and adjusted a later task timeout from 3h to 5h.
  • Bumped OCP release parameters to target 4.22.4 (major/minor/patch components) for both workflows.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie bfournie deleted the large-mem-platform branch July 9, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants