OCPBUGS-98101: Use build platform with more disk space#312
Conversation
|
@bfournie: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughTwo Tekton PipelineRun definitions were updated. The pull-request PipelineRun now uses a new build platform, updated OCP release values, and longer timeouts. The push PipelineRun now uses a new build platform and updated OCP release values. ChangesTekton PipelineRun updates
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
.tekton/ove-ui-iso-push.yaml (1)
29-30: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winTrailing whitespace in
build-platformsvalue.Same issue as in
ove-ui-iso-pull-request.yaml:linux-d160-m4xlarge/amd64has a trailing space, which risks a platform-name mismatch against the multi-platform-controller's configured host pools.🐛 Proposed fix
- name: build-platforms value: - - linux-d160-m4xlarge/amd64 + - linux-d160-m4xlarge/amd64🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.tekton/ove-ui-iso-push.yaml around lines 29 - 30, The build-platforms entry in the Tekton YAML has a trailing space in the linux-d160-m4xlarge/amd64 value, which can cause host-pool matching issues. Update the value in the platform list to remove the extra whitespace and keep it consistent with the other pipeline config that uses the same platform name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In @.tekton/ove-ui-iso-push.yaml:
- Around line 29-30: The build-platforms entry in the Tekton YAML has a trailing
space in the linux-d160-m4xlarge/amd64 value, which can cause host-pool matching
issues. Update the value in the platform list to remove the extra whitespace and
keep it consistent with the other pipeline config that uses the same platform
name.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: cf5394fe-180e-41bb-b3cb-702aa8c803b0
📒 Files selected for processing (2)
.tekton/ove-ui-iso-pull-request.yaml.tekton/ove-ui-iso-push.yaml
548977a to
542e181
Compare
542e181 to
38e986c
Compare
|
/test ci/prow/images |
|
/test images |
|
@bfournie: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by kflux-prd-rh02/ove-ui-iso-on-pull-request |
|
@bfournie: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bfournie: This pull request references Jira Issue OCPBUGS-98101, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@bfournie: This pull request references Jira Issue OCPBUGS-98101, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/unhold |
|
/lgtm |
|
@bfournie: Jira Issue Verification Checks: Jira Issue OCPBUGS-98101 Jira Issue OCPBUGS-98101 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Summary by CodeRabbit
linux-root/amd64tolinux-d320-m8xlarge/amd64and increasing the pipeline timeout from 4h to 5h.