Skip to content

OCPBUGS-99425: Use agent-preinstall-image-builder from quay-proxy#319

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bfournie:quay-proxy-migration
Jul 23, 2026
Merged

OCPBUGS-99425: Use agent-preinstall-image-builder from quay-proxy#319
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bfournie:quay-proxy-migration

Conversation

@bfournie

@bfournie bfournie commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The location of the agent-preinstall-image-builder is changed, update the urls.

Summary by CodeRabbit

  • Documentation
    • Updated ISO Builder guidance and command examples to use the new image registry endpoint.
  • Bug Fixes
    • Updated ISO build defaults and builder configuration to consistently reference the new image locations, improving build reliability.

The location of the agent-preinstall-image-builder is changed, update
the urls.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: This pull request references Jira Issue OCPBUGS-99425, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The location of the agent-preinstall-image-builder is changed, update the urls.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 358402cc-10c4-4397-a34e-ab76d670c165

📥 Commits

Reviewing files that changed from the base of the PR and between c456e33 and 652f2a5.

📒 Files selected for processing (4)
  • tools/iso_builder/CLAUDE.md
  • tools/iso_builder/Dockerfile
  • tools/iso_builder/hack/build-ove-image.sh
  • tools/iso_builder/hack/helper.sh

Walkthrough

ISO Builder Docker, script, documentation, and help-text image references were migrated from registry.ci.openshift.org to quay-proxy.ci.openshift.org, including appliance image defaults and release image examples.

Changes

ISO Builder registry migration

Layer / File(s) Summary
Update ISO Builder image references
tools/iso_builder/Dockerfile, tools/iso_builder/hack/build-ove-image.sh, tools/iso_builder/CLAUDE.md, tools/iso_builder/hack/helper.sh
Builder configuration and live ISO defaults use the quay-proxy.ci.openshift.org/openshift/ci image format, and documentation and help examples are updated accordingly.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: moving agent-preinstall-image-builder references to quay-proxy.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or modified; the PR only updates ISO builder image URLs in docs and shell scripts.
Test Structure And Quality ✅ Passed PR only updates ISO-builder docs and shell/image references; no Ginkgo test code or test assertions were changed.
Microshift Test Compatibility ✅ Passed PR only updates ISO builder docs/scripts and changes no Ginkgo e2e tests, so MicroShift compatibility review is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only iso_builder docs and shell scripts changed; no Ginkgo e2e tests or SNO-related assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only ISO builder docs/scripts and image URLs changed; no manifests, replicas, affinities, node selectors, or controller scheduling logic were introduced.
Ote Binary Stdout Contract ✅ Passed Only docs and shell scripts changed; no OTE binary main/init/TestMain/suite code or new stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only changes iso_builder docs/scripts; no new Ginkgo e2e tests were added, so this check is not applicable.
No-Weak-Crypto ✅ Passed Changed files only update image URLs/docs; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret/token comparisons were added.
Container-Privileges ✅ Passed Touched files only update image URLs/docs; no K8s/container manifest adds privileged flags, hostPID/IPC, SYS_ADMIN, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed The patch only swaps image registry URLs in docs and defaults; no passwords, tokens, PII, or secret-like values are logged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: This pull request references Jira Issue OCPBUGS-99425, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

The location of the agent-preinstall-image-builder is changed, update the urls.

Summary by CodeRabbit

  • Documentation
  • Updated ISO Builder guidance and command examples to use the new image registry endpoint.
  • Bug Fixes
  • Updated ISO build defaults and builder configuration to consistently reference the new image locations, improving build reliability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from celebdor and rwsu July 22, 2026 12:18
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2026
@bfournie

Copy link
Copy Markdown
Contributor Author

/test ?

@bfournie

Copy link
Copy Markdown
Contributor Author

/test e2e-agent-compact-ipv4-iso-no-registry

@bfournie

Copy link
Copy Markdown
Contributor Author

/retest

@bfournie

Copy link
Copy Markdown
Contributor Author

/retest-required

@bfournie

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bfournie

Copy link
Copy Markdown
Contributor Author

/verified by "Konflux kflux-prd-rh02 / ove-ui-iso-on-pull-request"

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: This PR has been marked as verified by "Konflux kflux-prd-rh02 / ove-ui-iso-on-pull-request".

Details

In response to this:

/verified by "Konflux kflux-prd-rh02 / ove-ui-iso-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 4c1ca15 into openshift:main Jul 23, 2026
14 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: Jira Issue Verification Checks: Jira Issue OCPBUGS-99425
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-99425 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

The location of the agent-preinstall-image-builder is changed, update the urls.

Summary by CodeRabbit

  • Documentation
  • Updated ISO Builder guidance and command examples to use the new image registry endpoint.
  • Bug Fixes
  • Updated ISO build defaults and builder configuration to consistently reference the new image locations, improving build reliability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
bfournie deleted the quay-proxy-migration branch July 23, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants