Skip to content

add observed generation to operator v1#137

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:generation
Nov 20, 2018
Merged

add observed generation to operator v1#137
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:generation

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Nov 19, 2018

We need to know when we have observed a particular generation of configuration.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 19, 2018
@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Nov 19, 2018

I see this type was added in 8453618 . Was it a conscious decision to not included this field in 8453618 and something has changes since that we now need this or this was always needed and we just missed it in #125 :P

Also i see that https://github.com/kubernetes/api/blob/master/apps/v1/types.go#L565 has //+optional when omitempty. Is that useful here?

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Nov 20, 2018

I see this type was added in 8453618 . Was it a conscious decision to not included this field in 8453618 and something has changes since that we now need this or this was always needed and we just missed it in #125 :P

Also i see that https://github.com/kubernetes/api/blob/master/apps/v1/types.go#L565 has //+optional when omitempty. Is that useful here?

I just missed it.

The optional tag is a directive to openapi generation. Most of our types don't use it consistently, but I can add it.

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Nov 20, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2018
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ffac7ee into openshift:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants