add observed generation to operator v1#137
add observed generation to operator v1#137openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
I see this type was added in 8453618 . Was it a conscious decision to not included this field in 8453618 and something has changes since that we now need this or this was always needed and we just missed it in #125 :P Also i see that https://github.com/kubernetes/api/blob/master/apps/v1/types.go#L565 has |
I just missed it. The optional tag is a directive to openapi generation. Most of our types don't use it consistently, but I can add it. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We need to know when we have observed a particular generation of configuration.