provide a basic operator v1 API#125
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
some comment updates here deads2k#1 |
| // PrereqsSatisfied indicates that the things this operator depends on are present and at levels compatible with the | ||
| // current and desired states. | ||
| OperatorStatusTypePrereqsSatisfied = "PrereqsSatisfied" | ||
| // Upgradeable indicates that the operator configuration itself (not prereqs) can be auto-upgraded by the CVO |
There was a problem hiding this comment.
PrereqsSatisfied could be False, but Upgradeable could be True, but only if i've set ManagementState to Force?
PrereqsSatisfied could be True, but Upgradeable can be False if I've done something to make my configuration invalid?
There was a problem hiding this comment.
PrereqsSatisfied could be False, but Upgradeable could be True, but only if i've set ManagementState to Force?
I would not adjust these based on Force. I would say that Force just makes you ignore them.
PrereqsSatisfied could be True, but Upgradeable can be False if I've done something to make my configuration invalid?
make your configuration unsupportable, not invalid. I think any patch makes it unsupportable and therefore unupgradeable, but doesn't affect prereqs being satisfied (apiserver version for instance)
| type OperandSpec struct { | ||
| // name is the name of this unit. The operator must be aware of it. | ||
| Name string `json:"name"` | ||
|
|
There was a problem hiding this comment.
Should we have replicas on OperandSpec
There was a problem hiding this comment.
Should we have
replicason OperandSpec
I'd rather not unless we have to. I'd like to think that the HPA could manage that for us. Any evidence one way or the other?
deads2k
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@jwforres I think this is up to date with our current thinking. |
operator/v1/register.go
Outdated
|
|
||
| var ( | ||
| GroupName = "operator.openshift.io" | ||
| GroupVersion = schema.GroupVersion{Group: GroupName, Version: "v1alpha1"} |
|
/lgtm |
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, jwforres The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
deads2k
added
lgtm
fixed |
5 participants
Provides a basic operator v1 API based on operator API design principles (available separately, addition charges may apply) and lessons learned from the first few attempts.
/assign @jwforres