[release-4.18] CNTRLPLANE-1610: Add feature gates for StreamingCollectionEncoding

[rh-roman]

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Adding a feature gate to allow customers to enable API streaming features.

[openshift-ci-robot]

@rh-roman: This pull request references CNTRLPLANE-1610 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.18.z" instead.

In response to this:

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Adding a feature gate to allow customers to enable API streaming features.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @rh-roman! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@rh-roman: This pull request references CNTRLPLANE-1610 which is a valid jira issue.

In response to this:

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Adding a feature gate to allow customers to enable API streaming features.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rh-roman]

/retest

[openshift-ci]

@rh-roman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-crdify	6d071af	link	true	/test verify-crdify
ci/prow/verify-feature-promotion	6d071af	link	true	/test verify-feature-promotion
ci/prow/lint	6d071af	link	true	/test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[everettraven]

/lgtm

[everettraven]

/label backport-risk-assessed
/label jira/valid-bug

[rh-roman]

/test lint

[openshift-ci]

@rh-roman: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test e2e-aws-ovn

/test e2e-aws-ovn-hypershift

/test e2e-aws-ovn-techpreview

/test e2e-aws-serial

/test e2e-aws-serial-techpreview

/test e2e-upgrade

/test images

/test integration

/test minor-e2e-upgrade-minor

/test minor-images

/test okd-scos-images

/test unit

/test verify

/test verify-client-go

/test verify-crd-schema

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-azure

/test e2e-gcp

/test okd-scos-e2e-aws-ovn

Use /test all to run all jobs.

In response to this:

/test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rh-roman]

/retest

[rh-roman]

/test all

[benluddy]

/test all

I think those three presubmits don't exist on 4.18, so the jobs we are seeing are an artifact of having initially opening this PR against master before updating the target branch. As long as tide is happy we should be good.

[everettraven]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: everettraven
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[everettraven]

Ah, I forgot - I already LGTM'd this but my approval didn't stick because I wasn't an approver in the OWNERS file all the way back to the 4.18 branch 🤦

@JoelSpeed will likely have to approve this when he is back.

[rh-roman]

Ah, I forgot - I already LGTM'd this but my approval didn't stick because I wasn't an approver in the OWNERS file all the way back to the 4.18 branch 🤦

I assumed you were so impressed you thought it deserved a second LGTM.