-
Notifications
You must be signed in to change notification settings - Fork 576
[release-4.17] CNTRLPLANE-1611: Add feature gates for StreamingCollectionEncoding #2538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.17] CNTRLPLANE-1611: Add feature gates for StreamingCollectionEncoding #2538
Conversation
|
@rh-roman: This pull request references CNTRLPLANE-1611 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @rh-roman! Some important instructions when contributing to openshift/api: |
|
@rh-roman How far back does this feature make sense to enable in tech preview? This is now going back to 1.30 upstream so the feature was in alpha at that point (beta 1.32) |
@JoelSpeed we were asked to backport it down to 4.16. Should it be enabled under a different feature set or not enabled at all? |
|
/test e2e-aws-serial-techpreview |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/hold cancel |
|
/verified by @rh-roman |
|
@rh-roman: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest Last run looked fine other than timing out during deprovision. Tide wants it to pass even though it's not required? |
|
/test e2e-aws-serial-techpreview |
|
@rh-roman: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
b410df2
into
openshift:release-4.17
Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157
Adding a feature gate to allow customers to enable API streaming features.