Skip to content

Conversation

@rh-roman
Copy link

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Adding a feature gate to allow customers to enable API streaming features.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2025

@rh-roman: This pull request references CNTRLPLANE-1611 which is a valid jira issue.

In response to this:

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Adding a feature gate to allow customers to enable API streaming features.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

Hello @rh-roman! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2025
@openshift-ci openshift-ci bot requested review from JoelSpeed and deads2k October 17, 2025 21:53
@JoelSpeed
Copy link
Contributor

@rh-roman How far back does this feature make sense to enable in tech preview? This is now going back to 1.30 upstream so the feature was in alpha at that point (beta 1.32)

@rh-roman
Copy link
Author

@rh-roman How far back does this feature make sense to enable in tech preview? This is now going back to 1.30 upstream so the feature was in alpha at that point (beta 1.32)

@JoelSpeed we were asked to backport it down to 4.16. Should it be enabled under a different feature set or not enabled at all?

@JoelSpeed
Copy link
Contributor

/test e2e-aws-serial-techpreview

@benluddy
Copy link
Contributor

/hold

openshift/kubernetes#2486

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025
@JoelSpeed
Copy link
Contributor

/lgtm
/label backport-risk-assessed
/label jira/valid-bug

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 21, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@rh-roman
Copy link
Author

/retest

@benluddy
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2025
@rh-roman
Copy link
Author

/verified by @rh-roman

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 22, 2025
@openshift-ci-robot
Copy link

@rh-roman: This PR has been marked as verified by @rh-roman.

In response to this:

/verified by @rh-roman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@benluddy
Copy link
Contributor

/retest

Last run looked fine other than timing out during deprovision. Tide wants it to pass even though it's not required?

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD db4fa2d and 2 for PR HEAD 427307a in total

@wangke19
Copy link

/test e2e-aws-serial-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

@rh-roman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b410df2 into openshift:release-4.17 Oct 23, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants