Allow JobTier=candidate in featuregate-test-analyzer with warning

[dgoodwin]

Candidate tier jobs are not covered by the Component Readiness main
view and lack standard regression protection mechanisms. This change
allows candidate as a valid JobTier value, includes candidate tier
results in the pass/fail calculation alongside other tiers, and emits
a non-blocking warning when candidate tier queries return data.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @dgoodwin! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 6df5a246-01e9-4806-9156-0612bf271d0a

📥 Commits

Reviewing files that changed from the base of the PR and between 30c2ef7 and 429b507.

📒 Files selected for processing (3)

• tools/codegen/cmd/featuregate-test-analyzer.go
• tools/codegen/cmd/featuregate-test-analyzer_test.go
• tools/codegen/pkg/sippy/json_types.go

---

📝 Walkthrough

Walkthrough

This change adds support for the candidate job tier to the feature gate test analyzer. The modifications introduce a new TierName field to track job tier sources in Sippy queries, extend testing result structures to detect candidate-tier test data, update tier validation logic to accept candidate as a valid tier value, and enhance validation reporting to emit warnings when candidate-tier results are detected. Unit tests verify both the tier validation and warning generation behavior for candidate-tier scenarios.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[JoelSpeed]

/lgtm
/verified by CI

[openshift-ci-robot]

@JoelSpeed: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

• The changed files don't match any pipeline_run_if_changed patterns
• All files match pipeline_skip_if_only_changed patterns
• No pipeline-controlled jobs are defined for the master branch

Use /test ? to see all available tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@dgoodwin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.