Skip to content

[WIP]: CNTRLPLANE-3375: Promote ExternalOIDCWithUpstreamParity to Default feature set#2843

Open
ShazaAldawamneh wants to merge 1 commit into
openshift:masterfrom
ShazaAldawamneh:CNTRLPLANE-3375
Open

[WIP]: CNTRLPLANE-3375: Promote ExternalOIDCWithUpstreamParity to Default feature set#2843
ShazaAldawamneh wants to merge 1 commit into
openshift:masterfrom
ShazaAldawamneh:CNTRLPLANE-3375

Conversation

@ShazaAldawamneh
Copy link
Copy Markdown
Contributor

@ShazaAldawamneh ShazaAldawamneh commented May 14, 2026

Part of CNTRLPLANE-3375. Must merge with sibling PR openshift/release#79310 to enable Default feature set periodic jobs.

Changes
Enable feature in Default and OKD feature sets
Regenerate CRD manifests (Authentication CRDs now consolidated)
Update feature gate documentation and OpenAPI schemas

Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 14, 2026

@ShazaAldawamneh: This pull request references CNTRLPLANE-3375 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Part of CNTRLPLANE-3375. Must merge with sibling PR openshift/release#79310 to enable Default feature set periodic jobs.

Changes
Enable feature in Default and OKD feature sets
Regenerate CRD manifests (Authentication CRDs now consolidated)
Update feature gate documentation and OpenAPI schemas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

Hello @ShazaAldawamneh! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 14, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a941e3dd-31cc-4d77-b411-c360f736b356

📥 Commits

Reviewing files that changed from the base of the PR and between 73d7ca9 and 37585b3.

⛔ Files ignored due to path filters (6)
  • config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_authentications-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_authentications-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_authentications-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_authentications-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_authentications.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
  • openapi/openapi.json is excluded by !openapi/**
📒 Files selected for processing (11)
  • features.md
  • features/features.go
  • payload-manifests/crds/0000_10_config-operator_01_authentications-Default.crd.yaml
  • payload-manifests/crds/0000_10_config-operator_01_authentications-DevPreviewNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_10_config-operator_01_authentications-OKD.crd.yaml
  • payload-manifests/crds/0000_10_config-operator_01_authentications-TechPreviewNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_10_config-operator_01_authentications.crd.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
💤 Files with no reviewable changes (5)
  • payload-manifests/crds/0000_10_config-operator_01_authentications-Default.crd.yaml
  • payload-manifests/crds/0000_10_config-operator_01_authentications.crd.yaml
  • payload-manifests/crds/0000_10_config-operator_01_authentications-OKD.crd.yaml
  • payload-manifests/crds/0000_10_config-operator_01_authentications-DevPreviewNoUpgrade.crd.yaml
  • payload-manifests/crds/0000_10_config-operator_01_authentications-TechPreviewNoUpgrade.crd.yaml

📝 Walkthrough

Walkthrough

This change enables the ExternalOIDCWithUpstreamParity feature gate for Default and OKD configurations in addition to existing preview configurations. Multiple Authentication CustomResourceDefinition variants are removed from feature-gated versions (DevPreviewNoUpgrade, TechPreviewNoUpgrade, and OKD), with only the default version retained and a feature-set annotation removed. Feature gate manifests across Hypershift and SelfManagedHA deployment configurations are updated to enable this feature. Documentation is reorganized to reflect the updated feature gate positioning.

Suggested reviewers

  • JoelSpeed
  • chiragkyal
  • melvinjoseph86
  • everettraven
🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning Ginkgo assertions lack meaningful failure messages on lines 178, 235, 270, 298, 332 (Expect(k8sClient.Get...)) and 137 (Expect(k8sClient.DeleteAllOf...)). Add diagnostic messages to bare Expect() calls: Expect(k8sClient.Get(ctx, key, obj), "context about what failed")
✅ Passed checks (11 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main objective of the PR: promoting the ExternalOIDCWithUpstreamParity feature to the Default feature set, which aligns with the changes across feature gate files and feature configuration.
Description check ✅ Passed The description is directly related to the changeset, clearly outlining the three main categories of changes: enabling the feature in Default and OKD sets, regenerating CRD manifests with consolidation, and updating feature gate documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only configuration files, manifests, and documentation - no Ginkgo test files are modified. The custom check for stable test names is not applicable.
Microshift Test Compatibility ✅ Passed PR does not add any new Ginkgo e2e tests. All changes are to feature configuration and payload manifests only. The MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. It only modifies feature gate configuration (Go code and YAML manifests) and documentation. The custom check for SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies feature gate configuration, CRD definitions, and documentation. No deployment manifests, operator code, or scheduling constraints are introduced. Check is not applicable.
Ote Binary Stdout Contract ✅ Passed This PR modifies openshift/api repo (definitions, features, manifests)—not OTE test binaries. No process-level stdout violations found in modified files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests were added in this PR. The changes consist of feature gate definitions, CRD manifests, and documentation updates only.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from JoelSpeed and everettraven May 14, 2026 15:05
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

@ShazaAldawamneh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-feature-promotion 37585b3 link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants