NE-2729: Add feature gate for multiple HAProxy versions

[jcmoraisjr]

Add the IngressControllerMultipleHAProxyVersions feature gate to control whether cluster-ingress-operator should deploy the router along with a specific HAProxy version, instead of using the embedded HAProxy installed in the router's image.

The feature gate is enabled in DevPreviewNoUpgrade and TechPreviewNoUpgrate stages.

Enhancement proposal: openshift/enhancements#1965

https://redhat.atlassian.net/browse/NE-2729

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@jcmoraisjr: This pull request references NE-2729 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Add the IngressControllerMultipleHAProxyVersions feature gate to control whether cluster-ingress-operator should deploy the router along with a specific HAProxy version, instead of using the embedded HAProxy installed in the router's image.

The feature gate is enabled in DevPreviewNoUpgrade and TechPreviewNoUpgrate stages.

Enhancement proposal: openshift/enhancements#1965

https://redhat.atlassian.net/browse/NE-2729

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @jcmoraisjr! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d458286e-7562-4cad-b3df-343eea40e99c

📥 Commits

Reviewing files that changed from the base of the PR and between 30525d5 and 6a8233b.

📒 Files selected for processing (10)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

---

📝 Walkthrough

Walkthrough

This PR introduces a new feature gate, IngressControllerMultipleHAProxyVersions, to the OpenShift API. The gate is first defined and registered in the Go codebase with associated metadata, then documented in the feature-gate table. The feature gate is subsequently configured across eight deployment manifests representing different cluster modes (HyperShift and SelfManagedHA) and configuration tiers (Default, DevPreviewNoUpgrade, OKD, and TechPreviewNoUpgrade), with the gate enabled in preview tiers and disabled in default and OKD tiers.

Suggested reviewers

• everettraven
• memodi

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a feature gate for multiple HAProxy versions, which aligns with all changes across the files.
Description check	✅ Passed	The description is directly related to the changeset, explaining the purpose of the feature gate and its enabled stages, which matches the modifications across all files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR contains no Ginkgo test files (features.md, features/features.go, and YAML manifests only). The check for stable test names is not applicable.
Test Structure And Quality	✅ Passed	PR contains no Ginkgo tests to review. Changes are feature gate definitions and YAML manifests only - not test code. Custom check for Ginkgo test quality is not applicable to this PR.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests added in this PR. Changes are limited to feature gate definitions, documentation, and YAML configuration files.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. Changes only include feature gate definitions and YAML manifests. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only adds a feature gate definition with no deployment manifests, operator code, or scheduling constraints affecting topology-aware scheduling.
Ote Binary Stdout Contract	✅ Passed	This is the openshift/api library repository, not an OTE binary. No executable binaries are built from it, making the OTE stdout contract check inapplicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds no Ginkgo e2e tests; only feature gate definition and configuration files. Check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jcmoraisjr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.