Skip to content

[release-4.21] OCPBUGS-85149: Backport GatewayAPIWithoutOLM feature gate as disabled#2864

Open
gcs278 wants to merge 1 commit into
openshift:release-4.21from
gcs278:backport-4.21-GatewayAPIWithoutOLM-off
Open

[release-4.21] OCPBUGS-85149: Backport GatewayAPIWithoutOLM feature gate as disabled#2864
gcs278 wants to merge 1 commit into
openshift:release-4.21from
gcs278:backport-4.21-GatewayAPIWithoutOLM-off

Conversation

@gcs278
Copy link
Copy Markdown
Contributor

@gcs278 gcs278 commented Jun 1, 2026

Summary

Backport the GatewayAPIWithoutOLM feature gate definition to release-4.21 with all feature sets disabled. The gate is present but OFF — no behavioral change.

Why

  1. Unblocks test backportsopenshift/origin#31139 needs the feature gate to exist so it can conditionally skip noOLM-dependent tests. Without the gate definition, the test backport can't compile.

  2. Enables cleaner future backports — there is ongoing discussion about backporting the full noOLM / Sail Library path to 4.21 to address OLM subscription management issues (catalog source conflicts, detached subscriptions, disconnected cluster support). Having the gate already present makes that backport significantly cleaner if we decide to proceed.

Either way, this PR is safe — the gate is disabled in all feature sets and introduces no functional change.

Changes

  • Add FeatureGateGatewayAPIWithoutOLM to features/features.go with no enableIn call (disabled everywhere)

Note: make update-payload-featuregates was not run because it produces unrelated regeneration changes against the 4.21 baseline. The feature gate manifests will be updated when the gate is enabled in a future change.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@gcs278: This pull request references Jira Issue OCPBUGS-85149, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-85148 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-85148 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport the GatewayAPIWithoutOLM feature gate definition to release-4.21 with all feature sets disabled. The gate is present but OFF — no behavioral change.

Why

  1. Unblocks test backportsopenshift/origin#31139 needs the feature gate to exist so it can conditionally skip noOLM-dependent tests. Without the gate definition, the test backport can't compile.

  2. Enables cleaner future backports — there is ongoing discussion about backporting the full noOLM / Sail Library path to 4.21 to address OLM subscription management issues (catalog source conflicts, detached subscriptions, disconnected cluster support). Having the gate already present makes that backport significantly cleaner if we decide to proceed.

Either way, this PR is safe — the gate is disabled in all feature sets and introduces no functional change.

Changes

  • Add FeatureGateGatewayAPIWithoutOLM to features/features.go with no enableIn call (disabled everywhere)
  • Regenerated payload feature gate manifests via make update-payload-featuregates — the original cherry-pick produced a dirty merge with unrelated feature gates from master; the regeneration ensures only GatewayAPIWithoutOLM is added cleanly against the 4.21 baseline (separate commit)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2026

Hello @gcs278! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 90bda70f-25dd-49d2-8870-6a0d74b33c10

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested a review from melvinjoseph86 June 1, 2026 17:50
@openshift-ci openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 1, 2026
@openshift-ci openshift-ci Bot requested review from JoelSpeed and jkyros June 1, 2026 17:50
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gcs278 gcs278 force-pushed the backport-4.21-GatewayAPIWithoutOLM-off branch from 50e3bb9 to 8becc10 Compare June 1, 2026 17:55
@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 1, 2026
Add the GatewayAPIWithoutOLM feature gate to release-4.21 with all
feature sets disabled. No behavioral change — the gate is present
but OFF. Unblocks cleaner backports of noOLM-dependent code and tests.

Cherry-picked from: a47ac12
openshift#2191
@gcs278 gcs278 force-pushed the backport-4.21-GatewayAPIWithoutOLM-off branch from 8becc10 to 4b25e2d Compare June 1, 2026 17:57
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2026

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants