[release-4.21] OCPBUGS-85149: Backport GatewayAPIWithoutOLM feature gate as disabled#2864
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@gcs278: This pull request references Jira Issue OCPBUGS-85149, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @gcs278! Some important instructions when contributing to openshift/api: |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
50e3bb9 to
8becc10
Compare
Add the GatewayAPIWithoutOLM feature gate to release-4.21 with all feature sets disabled. No behavioral change — the gate is present but OFF. Unblocks cleaner backports of noOLM-dependent code and tests. Cherry-picked from: a47ac12 openshift#2191
8becc10 to
4b25e2d
Compare
|
@gcs278: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Backport the
GatewayAPIWithoutOLMfeature gate definition to release-4.21 with all feature sets disabled. The gate is present but OFF — no behavioral change.Why
Unblocks test backports — openshift/origin#31139 needs the feature gate to exist so it can conditionally skip noOLM-dependent tests. Without the gate definition, the test backport can't compile.
Enables cleaner future backports — there is ongoing discussion about backporting the full noOLM / Sail Library path to 4.21 to address OLM subscription management issues (catalog source conflicts, detached subscriptions, disconnected cluster support). Having the gate already present makes that backport significantly cleaner if we decide to proceed.
Either way, this PR is safe — the gate is disabled in all feature sets and introduces no functional change.
Changes
FeatureGateGatewayAPIWithoutOLMtofeatures/features.gowith noenableIncall (disabled everywhere)Note:
make update-payload-featuregateswas not run because it produces unrelated regeneration changes against the 4.21 baseline. The feature gate manifests will be updated when the gate is enabled in a future change.