Update getLatestReleases to ignore non OCP releases

[JoelSpeed]

Ensure we ignore releases that are not for OCP, and then search the list for the most recently started development release (ignoring anything that hasn't started yet)

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: bf484654-ae8e-492d-a74c-b5e1a8dd9124

📥 Commits

Reviewing files that changed from the base of the PR and between 70f01b8 and d0ab229.

📒 Files selected for processing (1)

• tools/codegen/cmd/featuregate-test-analyzer.go

---

📝 Walkthrough

Walkthrough

This PR updates the getLatestRelease() function in the featuregate test analyzer to adapt to a new Sippy releases API response format. The function now unmarshals JSON data from a release_attrs map instead of separate releases and dates objects, filters releases to only those with product == "OCP", validates that development_start timestamps are non-zero and not in the future, tracks the most recent valid development_start, and returns an error message if no valid development releases are found.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Update getLatestReleases to ignore non OCP releases' accurately reflects the main change: filtering to include only OCP releases and selecting the most recently started development release.
Description check	✅ Passed	The description is directly related to the changeset, explaining that non-OCP releases are now ignored and the function searches for the most recently started development release.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test names in PR are static and descriptive. Test suite names from CRD metadata/filenames; test cases from static YAML specs. No dynamic values detected.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test structure is not applicable. PR modifies non-test file (featuregate-test-analyzer.go); repository uses standard Go testing, not Ginkgo.
Microshift Test Compatibility	✅ Passed	PR modifies a code generation tool (featuregate-test-analyzer.go), not Ginkgo e2e tests. Check applies only when new Ginkgo tests are added; no tests are present here.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests added in this PR. Changes are limited to a code generation tool's getLatestRelease() function, not e2e test code.
Topology-Aware Scheduling Compatibility	✅ Passed	Change is to a CLI tool (tools/codegen/cmd) that parses API responses, not a deployment manifest, operator code, or controller. No scheduling constraints introduced.
Ote Binary Stdout Contract	✅ Passed	Modified file is a code generation tool, not an OTE test binary. OTE Stdout Contract applies only to test binaries using JSON communication with openshift-tests.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No Ginkgo e2e tests added. PR only modifies tools/codegen/cmd/featuregate-test-analyzer.go, a code generation utility tool, not e2e tests.
No-Weak-Crypto	✅ Passed	PR modifies release filtering in featuregate-test-analyzer.go. No weak crypto (MD5/SHA1/DES/RC4) or custom implementations present. Only standard crypto/tls for HTTPS.
Container-Privileges	✅ Passed	PR modifies only Go source code (featuregate-test-analyzer.go); no container/K8s manifests with privilege settings are present or modified.
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive data is logged. The getLatestRelease() function processes API responses without logging the body content, and all error messages only include HTTP status codes or generic errors.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[stbenjam]

/lgtm

[JoelSpeed]

/approve

[openshift-merge-bot]

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

• The changed files don't match any pipeline_run_if_changed patterns
• All files match pipeline_skip_if_only_changed patterns
• No pipeline-controlled jobs are defined for the master branch

Use /test ? to see all available tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/verified by @JoelSpeed

Tested this locally and it is correctly picking up 5.0 now

[openshift-ci-robot]

@JoelSpeed: This PR has been marked as verified by @JoelSpeed.

Details

In response to this:

/verified by @JoelSpeed

Tested this locally and it is correctly picking up 5.0 now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.