Add project dashboard link to console api #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
jhadvig
force-pushed
the
namespaceDashboard
branch
from
cebd577 to
e555182
Compare
Member
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Member
|
/cc @bparees |
Contributor
|
/approve |
openshift-ci-robot
added
the
approved
spadgett
reviewed
Sep 20, 2019
console/v1/types_console_link.go
Outdated
|
|
||
| // NamespaceDashboardSpec is a specification of namespaces in which the dashboard link should appear. | ||
| type NamespaceDashboardSpec struct { | ||
| // namespaces is an array of namespaces in which the dashboard link should appear. |
Member
There was a problem hiding this comment.
Suggested change
| // namespaces is an array of namespaces in which the dashboard link should appear. | |
| // namespaces is an array of namespace names in which the dashboard link should appear. |
jhadvig
force-pushed
the
namespaceDashboard
branch
from
e555182 to
5d09125
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://jira.coreos.com/browse/CONSOLE-1709
/assign @spadgett
@rhamilto FYI