Update operator for project link API changes #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
Member
|
thanks @jhadvig ! /hold |
openshift-ci-robot
added
the
do-not-merge/hold
spadgett
reviewed
Sep 20, 2019
rhamilto
reviewed
Sep 20, 2019
jhadvig
force-pushed
the
namespaceDashboard
branch
from
12c1f93 to
114fd04
Compare
spadgett
reviewed
Sep 24, 2019
| properties: | ||
| namespaces: | ||
| type: array | ||
| description: Namespaces in which the dashboard link should appear. |
Member
There was a problem hiding this comment.
Looks like the doc text doesn't quite match openshift/api#431
| type: object | ||
| description: Object that holds information about namespaces in which the dashboard link should appear, and it is applicable only when location is set to NamespaceDashboard. If not specified, the link will appear in all namespaces. | ||
| required: | ||
| - namespaces |
Contributor
There was a problem hiding this comment.
Tiny nit, our other CRDs do list spacing like:
required:
- text # no indent required
- hrefTemplate # no ident required
yay yamls :)
Member
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
jhadvig
force-pushed
the
namespaceDashboard
branch
from
114fd04 to
d11879d
Compare
Member
Author
|
@spadgett @benjaminapetersen comments addressed. PTAL |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
NamespaceDashboardlocationStory: https://jira.coreos.com/browse/CONSOLE-1710
/assign @spadgett
@rhamilto FYI