Skip to content

Update Buildah in glide.yaml#64

Closed
TomSweeneyRedHat wants to merge 1 commit intoopenshift:masterfrom
TomSweeneyRedHat:dev/tsweeney/buildahv1.7.3
Closed

Update Buildah in glide.yaml#64
TomSweeneyRedHat wants to merge 1 commit intoopenshift:masterfrom
TomSweeneyRedHat:dev/tsweeney/buildahv1.7.3

Conversation

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor

Update Buildah to v1.7.3 along with a couple of
dependent projects. This addresses: https://jira.coreos.com/browse/RUN-362
and https://bugzilla.redhat.com/show_bug.cgi?id=1695622

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com

Update Buildah to v1.7.3 along with a couple of
dependent projects.  This addresses: https://jira.coreos.com/browse/RUN-362
and https://bugzilla.redhat.com/show_bug.cgi?id=1695622

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TomSweeneyRedHat
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bparees

If they are not already assigned, you can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

FYI @mrunalp @nalind @preethit

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@TomSweeneyRedHat: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-image-ecosystem 881e059 link /test e2e-aws-image-ecosystem
ci/prow/e2e-aws 881e059 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adambkaplan
Copy link
Copy Markdown
Contributor

/hold

@TomSweeneyRedHat unfortunately running the bump (via hack/update-deps.sh) introduces its own issues, since openshift/api and openshift/client-go now require go 1.11 and k8s 1.12.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2019
@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

@adambkaplan , @nalind told me that I neglected to run deps/update-dep.sh earlier today which I'm trying to do now, but it appears to be hanging. Is there anything else I can do/change to move this forward or am I in hurry up and wait mode at the moment?

@adambkaplan
Copy link
Copy Markdown
Contributor

@TomSweeneyRedHat - this has opened up a whole separate set of issues related to our k8s dependencies. Most of these we don't need in openshift/builder and should be ripped out.

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

@adambkaplan , @nalind had me adjust a couple things in the yaml and after retrying, I'm now seeing the below error when running hack/update-deps.sh. Is this due to the k8s dependencies you mentioned prior and any thoughts on how we might get around it?

[INFO]	--> Exporting gopkg.in/square/go-jose.v2
[ERROR]	Export failed for k8s.io/kubernetes: Unable to export source
[ERROR]	Export failed for github.com/openshift/origin: Unable to export source
[ERROR]	Unable to export dependencies to vendor directory: Unable to export source

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

Thanks to @nalind, he figured out my last issue was due to a lack of memory on my VM, bumped that up and now it's happy.

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

The VM that I'd this sandbox in got trashed over the weekend, and I'm not feeling good about where this branch stands in my new VM. I'm going to save my glide.yaml that I've redone and will create a new PR. I'm going to kill this one.

@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/buildahv1.7.3 branch April 23, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants