Skip to content

WIP - Update to Buildah 1.7.3#65

Closed
TomSweeneyRedHat wants to merge 2 commits intoopenshift:masterfrom
TomSweeneyRedHat:dev/tsweeney/buildah1.7.3-1
Closed

WIP - Update to Buildah 1.7.3#65
TomSweeneyRedHat wants to merge 2 commits intoopenshift:masterfrom
TomSweeneyRedHat:dev/tsweeney/buildah1.7.3-1

Conversation

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor

@TomSweeneyRedHat TomSweeneyRedHat commented Apr 23, 2019

Update to Buildah 1.7.3. A WIP for now as I've compile
time issues I need to work through with @nalind

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com

@TomSweeneyRedHat
WIP - Update to Buildah 1.7.3
a7907fd 
Update to Buildah 1.7.3.  A WIP for now as I've compile
time issues I need to work through with @nalind

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 23, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 23, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TomSweeneyRedHat
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bparees

If they are not already assigned, you can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

TomSweeneyRedHat commented Apr 23, 2019 •
edited
Loading

Replaces #64

@TomSweeneyRedHat
Second vndr with go-client ver and lib fixes
b8b9ecc 
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

TomSweeneyRedHat commented Apr 23, 2019

@nalind, just pushed with all changes to date, will see what the CI thinks of it.

@nalind
Copy link
Copy Markdown
Member

nalind commented Apr 23, 2019

A few of these failures are happening because we changed "[Warning] One or more build-args %v were not consumed\n" to "[Warning] one or more build args were not consumed: %v\n" when checking for unused build args.

@nalind nalind mentioned this pull request Apr 23, 2019
Merged
@nalind
Copy link
Copy Markdown
Member

nalind commented Apr 29, 2019

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 29, 2019

@TomSweeneyRedHat: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-image-ecosystem b8b9ecc link /test e2e-aws-image-ecosystem
ci/prow/e2e-aws-builds b8b9ecc link /test e2e-aws-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

TomSweeneyRedHat commented May 2, 2019

Closing in favor of #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhgupta abhgupta Awaiting requested review from abhgupta

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomSweeneyRedHat @openshift-ci-robot @nalind