CM-1367: Bump trust-manager operand to v0.24.0

[arun717]

Summary

• Bump the trust-manager operand from v0.20.3 to v0.24.0 (Makefile, RELATED_IMAGE / CSV, Helm bindata, Bundle CRD).
• Apply Helm 0.24 trust-manager-cluster-view (read-only bundles + aggregate-to-cluster-reader). This stays a separate ClusterRole so cluster-reader does not inherit operand write rules.

This is the operand half of CM-1367. The TrustManager filterNonCACerts API lives in #494. Merge this PR first: --filter-non-ca-certs exists only from v0.21.0, so 494’s Enabled path will CrashLoop a v0.20.3 operand.

Jira: https://issues.redhat.com/browse/CM-1367

Notes for reviewers

• Bundle CRD diff is regenerated with make bundle. Content is v0.24 schema (CEL, length limits, descriptions), not a YAML reformat. Helm output stays in config/crd/bases/; do not copy it onto bundle/manifests/.
• test/go.mod stays github.com/cert-manager/trust-manager v0.20.3. go get @v0.24.0 pulled k8s 0.36 and broke openshift/api. E2e talks to the live Bundle CRD, not that module’s types.
• images/ci/trustmanager.Dockerfile sets RELEASE_BRANCH=v0.24.0 and clones openshift/cert-manager-trust-manager. That fork’s latest tag is still v0.20.3; the Dockerfile clone will fail until midstream has the tag. CSV/RELATED_IMAGE uses quay.io/jetstack/trust-manager:v0.24.0.
• cluster-view is applied at the end of RBAC reconcile. UpdateResourceLabels replaces labels, so the aggregate label is set again after that.

Test plan

• Confirm CSV / manager related image is quay.io/jetstack/trust-manager:v0.24.0
• TrustManager Ready on v0.24.0 with default args (no --filter-non-ca-certs)
• oc get clusterrole trust-manager-cluster-view and cluster-reader aggregation
• CI e2e that already covers TrustManager (no new API in this PR)

Summary by CodeRabbit

• New Features

  • Added automatic private-key rotation for trust-manager certificates.
  • Added cluster-reader access to Bundle resources through a new aggregated role.
  • Added stricter Bundle validation for source types, targets, formats, names, keys, and status fields.
  • Added clearer metrics service labeling.

• Enhancements

  • Updated trust-manager components and deployment images to version 0.24.0.
  • Expanded event permissions to support the current Kubernetes events API.
  • Improved Bundle schema descriptions and validation feedback.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@arun717: This pull request references CM-1367 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

• Bump the trust-manager operand from v0.20.3 to v0.24.0 (Makefile, RELATED_IMAGE / CSV, Helm bindata, Bundle CRD).
• Apply Helm 0.24 trust-manager-cluster-view (read-only bundles + aggregate-to-cluster-reader). This stays a separate ClusterRole so cluster-reader does not inherit operand write rules.

This is the operand half of CM-1367. The TrustManager filterNonCACerts API lives in #494. Merge this PR first: --filter-non-ca-certs exists only from v0.21.0, so 494’s Enabled path will CrashLoop a v0.20.3 operand.

Jira: https://issues.redhat.com/browse/CM-1367

Notes for reviewers

• Bundle CRD diff is regenerated with make bundle. Content is v0.24 schema (CEL, length limits, descriptions), not a YAML reformat. Helm output stays in config/crd/bases/; do not copy it onto bundle/manifests/.
• test/go.mod stays github.com/cert-manager/trust-manager v0.20.3. go get @v0.24.0 pulled k8s 0.36 and broke openshift/api. E2e talks to the live Bundle CRD, not that module’s types.
• images/ci/trustmanager.Dockerfile sets RELEASE_BRANCH=v0.24.0 and clones openshift/cert-manager-trust-manager. That fork’s latest tag is still v0.20.3; the Dockerfile clone will fail until midstream has the tag. CSV/RELATED_IMAGE uses quay.io/jetstack/trust-manager:v0.24.0.
• cluster-view is applied at the end of RBAC reconcile. UpdateResourceLabels replaces labels, so the aggregate label is set again after that.

Test plan

• Confirm CSV / manager related image is quay.io/jetstack/trust-manager:v0.24.0
• TrustManager Ready on v0.24.0 with default args (no --filter-non-ca-certs)
• oc get clusterrole trust-manager-cluster-view and cluster-reader aggregation
• CI e2e that already covers TrustManager (no new API in this PR)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9ab2cc29-544d-4d00-981d-5dae1962cd3b

📥 Commits

Reviewing files that changed from the base of the PR and between d14c519 and 8270661.

📒 Files selected for processing (24)

• Makefile
• bindata/trust-manager/resources/certificate_trust-manager.yml
• bindata/trust-manager/resources/clusterrole_trust-manager-cluster-view.yml
• bindata/trust-manager/resources/clusterrole_trust-manager.yml
• bindata/trust-manager/resources/clusterrolebinding_trust-manager.yml
• bindata/trust-manager/resources/deployment_trust-manager.yml
• bindata/trust-manager/resources/issuer_trust-manager.yml
• bindata/trust-manager/resources/role_trust-manager.yml
• bindata/trust-manager/resources/role_trust-manager:leaderelection.yml
• bindata/trust-manager/resources/rolebinding_trust-manager.yml
• bindata/trust-manager/resources/rolebinding_trust-manager:leaderelection.yml
• bindata/trust-manager/resources/service_trust-manager-metrics.yml
• bindata/trust-manager/resources/service_trust-manager.yml
• bindata/trust-manager/resources/serviceaccount_trust-manager.yml
• bindata/trust-manager/resources/validatingwebhookconfiguration_trust-manager.yml
• bundle/manifests/cert-manager-operator.clusterserviceversion.yaml
• bundle/manifests/trust.cert-manager.io_bundles.yaml
• config/crd/bases/customresourcedefinition_bundles.trust.cert-manager.io.yml
• config/manager/manager.yaml
• images/ci/trustmanager.Dockerfile
• pkg/controller/trustmanager/constants.go
• pkg/controller/trustmanager/rbacs.go
• pkg/controller/trustmanager/rbacs_test.go
• pkg/operator/assets/bindata.go

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

Walkthrough

The change upgrades trust-manager from v0.20.3 to v0.24.0. It updates Kubernetes assets, strengthens Bundle CRD validation, removes the /packages volume, enables certificate private-key rotation, and adds cluster-view RBAC reconciliation.

Changes

Trust-manager upgrade

Layer / File(s)	Summary
Bundle CRD validation bundle/manifests/trust.cert-manager.io_bundles.yaml, config/crd/bases/customresourcedefinition_bundles.trust.cert-manager.io.yml	Bundle sources, targets, metadata, formats, and status fields gain updated descriptions, length limits, property limits, and CEL validation.
Release and workload manifests Makefile, config/manager/manager.yaml, images/ci/trustmanager.Dockerfile, bundle/manifests/cert-manager-operator.clusterserviceversion.yaml, bindata/trust-manager/resources/*, pkg/operator/assets/bindata.go	Trust-manager references and labels update to v0.24.0. The certificate enables automatic private-key rotation. The deployment removes the /packages volume. Event permissions use events.k8s.io.
Cluster-view RBAC reconciliation bindata/trust-manager/resources/clusterrole_trust-manager-cluster-view.yml, pkg/controller/trustmanager/constants.go, pkg/controller/trustmanager/rbacs.go, pkg/controller/trustmanager/rbacs_test.go, pkg/operator/assets/bindata.go	A read-only trust-manager-cluster-view ClusterRole is embedded, registered, labeled for cluster-reader aggregation, reconciled, and covered by drift and policy tests.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant RBACReconciler
  participant AssetStore
  participant KubernetesAPI
  participant ClusterReader
  RBACReconciler->>AssetStore: Load cluster-view ClusterRole asset
  RBACReconciler->>KubernetesAPI: Get and server-side apply ClusterRole
  KubernetesAPI->>ClusterReader: Aggregate bundle read access
  KubernetesAPI-->>RBACReconciler: Return reconciliation result

Loading

Merge Risk: ⚪ Minimal · up to 82706

The trust-manager upgrade consistently updates deployment metadata, images, generated assets, CRD validation, and read-only Bundle RBAC without an identified merge-blocking regression.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 4 files. (20 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary change: updating the trust-manager operand to v0.24.0. This matches the version updates and related asset changes in the pull request.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The PR changes one test case name: cluster-view cluster role has correct metadata and aggregate label. It is a static string with no pod name, namespace, timestamp, UUID, node name, IP address…
Test Structure And Quality	✅ Passed	PASS. The only changed test file is pkg/controller/trustmanager/rbacs_test.go, and it uses Go testing.T table tests with a fake client, not Ginkgo It blocks. The PR adds no Eventually, `Consis…
Microshift Test Compatibility	✅ Passed	The pull request adds no new Ginkgo e2e tests. The only changed test file, pkg/controller/trustmanager/rbacs_test.go, uses Go's standard testing package and Test... functions. Its changes add un…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added. The authoritative PR diff changes only pkg/controller/trustmanager/rbacs_test.go as a test file, and it contains standard testing.T unit tests with no Ginkgo de…
Topology-Aware Scheduling Compatibility	✅ Passed	No topology-incompatible scheduling constraint is introduced. The trust-manager Deployment keeps its existing replicas: 1 and nodeSelector: kubernetes.io/os: linux; the patch changes only versions…
Ote Binary Stdout Contract	✅ Passed	PASS: The authoritative PR diff changes 24 files, but no process-level entry point or OTE suite setup file. The added Go code is RBAC reconciliation, test fixtures, constants, and generated asset lite…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request adds no Ginkgo e2e tests. The only changed test is pkg/controller/trustmanager/rbacs_test.go, which uses standard Go testing functions and tests RBAC objects with fake clien…
No-Weak-Crypto	✅ Passed	The authoritative pull-request diff introduces no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage. The added Go code only reconciles Kubernetes RBAC resources and imports no crypto packages or compa…
Container-Privileges	✅ Passed	No stated container privilege violation is introduced. The changed trust-manager Deployment retains allowPrivilegeEscalation: false, drops all capabilities, uses runAsNonRoot: true, and has no hos…
No-Sensitive-Data-In-Logs	✅ Passed	No changed code logs passwords, tokens, API keys, PII, session IDs, hostnames, or customer data. The new RBAC logs use the fixed resource name trust-manager-cluster-view; the new event also records …

Full details: Docstring Coverage

Explanation

Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 4 files. (20 skipped: 20 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arun717
Once this PR has been reviewed and has the lgtm label, please assign mytreya-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@arun717: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-operator-tech-preview	8270661	link	false	/test e2e-operator-tech-preview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.