Skip to content

Add OSDe2e test harness to certman operator#295

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
YiqinZhang:sdcicd1328-new
Sep 23, 2024
Merged

Add OSDe2e test harness to certman operator#295
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
YiqinZhang:sdcicd1328-new

Conversation

@YiqinZhang
Copy link
Contributor

@YiqinZhang YiqinZhang commented Sep 18, 2024

  • Add the osde2e test harness and migrated tests from osde2e. This includes improvements to the tests to not depend on osde2e.
  • Modified manager.Options to have no specified namespace and port.
$ make lint
...
main.go:1: : # github.com/openshift/certman-operator
./main.go:149:3: unknown field Namespace in struct literal of type manager.Options
./main.go:151:3: unknown field Port in struct literal of type manager.Options
./main.go:156:3: unknown field MetricsBindAddress in struct literal of type manager.Options
./main.go:164:11: options.Namespace undefined (type manager.Options has no field or method Namespace)
./main.go:165:28: undefined: cache.MultiNamespacedCacheBuilder (typecheck)
/*
make: *** [boilerplate/openshift/golang-osd-operator/standard.mk:186: go-check] Error 1
  • Commented out the CertificateReques status assertion as it fails on controller-runtime v0.16.3.
    The test client does not update the status of the cert runtime object, likely due to the addition of the WithStatusSubresource() functionality..

SDCICD-1326

@openshift-ci openshift-ci bot requested review from aliceh and tnierman September 18, 2024 21:15
@codecov
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.09%. Comparing base (862a8f2) to head (649c8ab).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
main.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   48.51%   49.09%   +0.57%     
==========================================
  Files          28       28              
  Lines        2092     2088       -4     
==========================================
+ Hits         1015     1025      +10     
+ Misses        970      960      -10     
+ Partials      107      103       -4     
Flag Coverage Δ
49.09% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
main.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@clcollins
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 20, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bb63295 and 2 for PR HEAD f28c5f9 in total

@YiqinZhang
Copy link
Contributor Author

/retest

1 similar comment
@MrSantamaria
Copy link

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bb63295 and 2 for PR HEAD f28c5f9 in total

@YiqinZhang
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2024
@YiqinZhang
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2024

@YiqinZhang: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@clcollins
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins, YiqinZhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7690ae5 into openshift:master Sep 23, 2024
clcollins added a commit to clcollins/certman-operator that referenced this pull request Sep 23, 2024
openshift-merge-bot bot added a commit that referenced this pull request Sep 23, 2024
Revert "Merge pull request #295 from YiqinZhang/sdcicd1328-new"
YiqinZhang added a commit to YiqinZhang/certman-operator that referenced this pull request Sep 23, 2024
openshift-merge-bot bot added a commit that referenced this pull request Oct 3, 2024
Reapply "Merge pull request #295 from YiqinZhang/sdcicd1328-new"
anispate added a commit to anispate/certman-operator that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants