Add OSDe2e test harness to certman operator#295
Add OSDe2e test harness to certman operator#295openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 48.51% 49.09% +0.57%
==========================================
Files 28 28
Lines 2092 2088 -4
==========================================
+ Hits 1015 1025 +10
+ Misses 970 960 -10
+ Partials 107 103 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
f28c5f9 to
61c9c52
Compare
|
/retest |
|
@YiqinZhang: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clcollins, YiqinZhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Revert "Merge pull request #295 from YiqinZhang/sdcicd1328-new"
…new" This reverts commit 57eb333.
Reapply "Merge pull request #295 from YiqinZhang/sdcicd1328-new"
manager.Optionsto have no specified namespace and port.CertificateRequesstatus assertion as it fails on controller-runtime v0.16.3.The test client does not update the status of the cert runtime object, likely due to the addition of the WithStatusSubresource() functionality..
SDCICD-1326