Skip to content

fix(fips): unified module validation with version-gated artifact checks#335

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
smith-xyz:fix/fips-module-checking-improvements
May 14, 2026
Merged

fix(fips): unified module validation with version-gated artifact checks#335
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
smith-xyz:fix/fips-module-checking-improvements

Conversation

@smith-xyz

Copy link
Copy Markdown
Contributor

Replace separate artifact and host lib checks with unified per-module
ValidateModule that tries RPM + version range + file gate, then falls
back to host lib FIPS symbols. Adds certified_artifact_max_version to
scope entries to specific release lines (e.g. openssl-libs 1.1.1 for
RHEL 8). Config now declares all CMVP-certified modules explicitly.

Supports Go native FIPS via artifact_source="binary" with config-driven
minimum version for GOFIPS140 build setting.

Fixes: #332

@openshift-ci openshift-ci Bot requested review from rhmdnd and rphillips May 14, 2026 19:35
@openshift-ci

openshift-ci Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smith-xyz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2026
@openshift-ci

openshift-ci Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

@smith-xyz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@smith-xyz

Copy link
Copy Markdown
Contributor Author

tested on all nightlies - passed:

registry.ci.openshift.org/ocp/release:4.12.0-0.nightly-2026-05-06-095208
registry.ci.openshift.org/ocp/release:4.13.0-0.nightly-2026-05-11-192047
registry.ci.openshift.org/ocp/release:4.14.0-0.nightly-2026-05-07-213817
registry.ci.openshift.org/ocp/release:4.15.0-0.nightly-2026-05-06-215654
registry.ci.openshift.org/ocp/release:4.16.0-0.nightly-2026-05-14-021554
registry.ci.openshift.org/ocp/release:4.17.0-0.nightly-2026-05-14-020539
registry.ci.openshift.org/ocp/release:4.18.0-0.nightly-2026-05-13-164455
registry.ci.openshift.org/ocp/release:4.19.0-0.nightly-2026-05-13-043200
registry.ci.openshift.org/ocp/release:4.20.0-0.nightly-2026-05-13-153530
registry.ci.openshift.org/ocp/release:4.21.0-0.nightly-2026-05-12-052734
registry.ci.openshift.org/ocp/release:4.22.0-0.nightly-2026-05-13-154759
registry.ci.openshift.org/ocp/release-5:5.0.0-0.nightly-2026-05-12-025124

@richardsonnick

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 957765a into openshift:main May 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Go native FIPS 140-3 module (GOFIPS140) binaries

2 participants