testgrid-config-generator: Correct some faulty assumptions#193
Conversation
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
The publish steps inside the release config are not good indicators of ocp or okd. Instead, the naming conventions chosen by the release should be used. Fix a bug where the periodics were added to both dashboards by checking for the correct convention. Also revert the run.sh script to be correct.
smarterclayton
force-pushed
the
testgrid_2
branch
from
e124e63 to
df49b2f
Compare
openshift-ci-robot
added
size/L
| logrus.Infof("release is not recognized: %s", releaseConfig.Name) | ||
| return nil | ||
| } | ||
| m := reVersion.FindStringSubmatch(releaseConfig.Name) |
There was a problem hiding this comment.
Yeah, the publish tags aren't guaranteed to match releases, names are
stevekuznetsov
left a comment
stevekuznetsov
left a comment
There was a problem hiding this comment.
I don't like fragile regex-based implementations ... why isn't the output check correct?
|
Tag publishing doesn't have anything to do with release versioning - we have examples where we would publish to 4.3 from other places, and OKD is just accidental. Publishing is a pipeline thing, not identifying what release this is. Names define what releases things are. |
|
The regex is less fragile than the publishing thing, because the publishing thing should be able to change at will to target other locations. |
|
yuck/10 /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
The publish steps inside the release config are not good indicators of ocp or okd. Instead, the naming conventions chosen by the release should be used.
-openshift-origin-meansokdin a job, andX.Y.Z-0.cifor release name also meansokd. The okd release streams are downstream of CI and can be ignored for now.Fix a bug where the periodics were added to both dashboards by checking for the correct convention. Also revert the run.sh script to be correct and add a generate mode.
/assign @stevekuznetsov