Skip to content

OCPBUGS-95558: Bump golang.org/x/crypto to v0.52.0#406

Open
jkaurredhat wants to merge 1 commit into
openshift:release-4.22from
jkaurredhat:update-xcrypto-4.22
Open

OCPBUGS-95558: Bump golang.org/x/crypto to v0.52.0#406
jkaurredhat wants to merge 1 commit into
openshift:release-4.22from
jkaurredhat:update-xcrypto-4.22

Conversation

@jkaurredhat

@jkaurredhat jkaurredhat commented Jul 20, 2026

Copy link
Copy Markdown

Summary

This PR addresses CVE-2026-46597 by bumping golang.org/x/crypto from v0.46.0 to v0.52.0, which includes a fix for a Denial of Service vulnerability in the SSH AES-GCM packet decoder.

Changes

  • Updated golang.org/x/crypto from v0.46.0 to v0.52.0
  • Updated transitive dependencies: golang.org/x/net, golang.org/x/sys, golang.org/x/term, golang.org/x/text, golang.org/x/tools
  • Ran go mod tidy and go mod vendor
  • Updated vendor directory with security patches

This update addresses CVE-2026-46597 (golang.org/x/crypto/ssh Denial of
Service vulnerability).

An incorrectly placed cast from bytes to int allowed for server-side panic
in the AES-GCM packet decoder for well-crafted inputs. This fix changes the
behavior to prevent the panic.

Updated golang.org/x/crypto from v0.46.0 to v0.52.0 to address this
security issue.

Related: OCPBUGS-95558
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@jkaurredhat: This pull request references Jira Issue OCPBUGS-95558, which is invalid:

  • expected Jira Issue OCPBUGS-95558 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This PR addresses CVE-2026-46597 by bumping golang.org/x/crypto from v0.46.0 to v0.52.0, which includes a fix for a Denial of Service vulnerability in the SSH AES-GCM packet decoder.

Changes

  • Updated golang.org/x/crypto from v0.46.0 to v0.52.0
  • Updated transitive dependencies: golang.org/x/net, golang.org/x/sys, golang.org/x/term, golang.org/x/text, golang.org/x/tools
  • Ran go mod tidy and go mod vendor
  • Updated vendor directory with security patches

CVE Details

CVE-2026-46597: golang.org/x/crypto/ssh: Denial of Service via crafted AES-GCM packet decoder inputs

  • Severity: Medium
  • Affected: golang.org/x/crypto/ssh < v0.52.0
  • Impact: An incorrectly placed cast from bytes to int allowed for server-side panic in the AES-GCM packet decoder for well-crafted inputs
  • Fix: Corrected the type conversion to prevent panic
  • Affected symbols: Dial, NewClientConn, NewServerConn

Test Plan

  • go get successful
  • go mod tidy successful
  • go mod vendor successful
  • Go version preserved (1.25.5)
  • CI tests pass
  • Security team review

References

Related

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6733e878-7d8a-40e3-910b-de87cd15dbf9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from gryf and stephenfin July 20, 2026 14:32
@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jkaurredhat
Once this PR has been reviewed and has the lgtm label, please assign romanbednar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown

@jkaurredhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 4a9a7fa link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants