OCPBUGS-74426: CAPI IPAM CRDs override storage version to v1beta1

[damdo]

Pin IPAM CRDs to use v1beta1 as the storage version.

Upstream CAPI did set v1beta2 as storage version immediately after it was added,
but according to our downstream policy, a new APIVersion cannot be set as storage version
in the same release it gets added. As this would hinder the ability to roll it back in case of an issue.
As such we need to pin the storage version to v1beta1 for at least the first release we GA cluster-api.
After that, we can bump the storage version to v1beta2, and run the storage version migration.

[openshift-ci-robot]

@damdo: This pull request references Jira Issue OCPBUGS-74426, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Pin IPAM CRDs to use v1beta1 as the storage version.

Upstream CAPI did set v1beta2 as storage version immediately after it was added,
but according to our downstream policy, a new APIVersion cannot be set as storage version
in the same release it gets added. As this would hinder the ability to roll it back in case of an issue.
As such we need to pin the storage version to v1beta1 for at least the first release we GA cluster-api.
After that, we can bump the storage version to v1beta2, and run the storage version migration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/assign @JoelSpeed @mdbooth

[damdo]

/hold

For testing

[mdbooth]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [damdo,mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sunzhaohua2]

/verified by @sunzhaohua2

$ oc get crd ipaddresses.ipam.cluster.x-k8s.io -o jsonpath='{.spec.versions[?(@.storage==true)].name}'   
v1beta1%
$ oc get crd ipaddressclaims.ipam.cluster.x-k8s.io -o jsonpath='{.spec.versions[?(@.storage==true)].name}'  
v1beta1%

[openshift-ci-robot]

@sunzhaohua2: This PR has been marked as verified by @sunzhaohua2.

Details

In response to this:

/verified by @sunzhaohua2

$ oc get crd ipaddresses.ipam.cluster.x-k8s.io -o jsonpath='{.spec.versions[?(@.storage==true)].name}'   
v1beta1%
$ oc get crd ipaddressclaims.ipam.cluster.x-k8s.io -o jsonpath='{.spec.versions[?(@.storage==true)].name}'  
v1beta1%

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/unhold

[openshift-ci-robot]

@damdo: Jira Issue Verification Checks: Jira Issue OCPBUGS-74426
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-74426 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Pin IPAM CRDs to use v1beta1 as the storage version.

Upstream CAPI did set v1beta2 as storage version immediately after it was added,
but according to our downstream policy, a new APIVersion cannot be set as storage version
in the same release it gets added. As this would hinder the ability to roll it back in case of an issue.
As such we need to pin the storage version to v1beta1 for at least the first release we GA cluster-api.
After that, we can bump the storage version to v1beta2, and run the storage version migration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.