NO-JIRA: IPAM CRDs: Use negated feature-gate: -ClusterAPIMachineManagement instead of feature-set: Default

[damdo]

Instead of using the Default feature-set, we want to use a negated feature-gate, as we want to deploy these resources only when the Feature Gate is off.

As such when the FeatureGate is on/on promotion they are deployed/managed by the CAPI Installer controller in cluster-capi-operator.

[openshift-ci-robot]

@damdo: This pull request explicitly references no jira issue.

Details

In response to this:

Instead of using the Default feature-set, we want to use a negated feature-gate, as we want to deploy these resources only when the Feature Gate is off.

As such when the FeatureGate is on/on promotion they are deployed/managed by the CAPI Installer controller in cluster-capi-operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/assign @JoelSpeed @mdbooth @theobarberbany

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 95d1ec1f-3150-4f0a-8831-3c2e9500dd55

📥 Commits

Reviewing files that changed from the base of the PR and between ee74192 and 25387a8.

📒 Files selected for processing (2)

• openshift/ipam/kustomization.yaml
• openshift/manifests/0000_30_cluster-api_04_crd.core-cluster-api.yaml

---

Walkthrough

Updated release annotations in ClusterAPI IPAM configuration files by replacing feature-set eligibility restrictions with feature-gate restrictions. Changed release.openshift.io/feature-set: Default to release.openshift.io/feature-gate: -ClusterAPIMachineManagement across kustomization and CRD manifest files, altering install eligibility logic.

Changes

Cohort / File(s)	Summary
ClusterAPI IPAM Feature Gate Annotations openshift/ipam/kustomization.yaml, openshift/manifests/0000_30_cluster-api_04_crd.core-cluster-api.yaml	Updated commonAnnotations and CRD metadata to replace release.openshift.io/feature-set: Default with release.openshift.io/feature-gate: -ClusterAPIMachineManagement, changing install eligibility from feature-set based to feature-gate based restriction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[theobarberbany]

TIL we can negate CVO feature gates

/lgtm
/approve

[JoelSpeed]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [damdo,theobarberbany]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

Updated release annotations in ClusterAPI IPAM configuration files by replacing feature-set eligibility restrictions with feature-gate restrictions. Changed release.openshift.io/feature-set: Default to release.openshift.io/feature-gate: -ClusterAPIMachineManagement across kustomization and CRD manifest files, altering install eligibility logic.

Changes

Cohort / File(s)	Summary
ClusterAPI IPAM Feature Gate Annotations openshift/ipam/kustomization.yaml, openshift/manifests/0000_30_cluster-api_04_crd.core-cluster-api.yaml	Updated commonAnnotations and CRD metadata to replace release.openshift.io/feature-set: Default with release.openshift.io/feature-gate: -ClusterAPIMachineManagement, changing install eligibility from feature-set based to feature-gate based restriction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[damdo]

/verified by ci/prow/e2e-vsphere-staticip-ipam-ovn passing

[openshift-ci-robot]

@damdo: This PR has been marked as verified by ci/prow/e2e-vsphere-staticip-ipam-ovn passing.

Details

In response to this:

/verified by ci/prow/e2e-vsphere-staticip-ipam-ovn passing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.