Skip to content

Conversation

@s-urbaniak
Copy link
Contributor

This removes the InvalidProviderInvalidCertsUpgradeable condition present in 4.9. This condition is not present in 4.10 any more as the controller setting it is removed.

The underlying reason is that invalid certs were tolerated in 4.9, however in 4.10 they won't work at all any more because of the Go version being used, see https://bugzilla.redhat.com/show_bug.cgi?id=2037274#c23.

/cc @deads2k @stlaz @mfojtik

@openshift-ci openshift-ci bot requested review from deads2k, mfojtik and stlaz May 17, 2023 11:54
@s-urbaniak s-urbaniak changed the title pkg/operator/starter: add InvalidProviderInvalidCertsUpgradeable to stale conditions OCPBUGS-12907: pkg/operator/starter: add InvalidProviderInvalidCertsUpgradeable to stale conditions May 17, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 17, 2023
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Jira Issue OCPBUGS-12907, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This removes the InvalidProviderInvalidCertsUpgradeable condition present in 4.9. This condition is not present in 4.10 any more as the controller setting it is removed.

The underlying reason is that invalid certs were tolerated in 4.9, however in 4.10 they won't work at all any more because of the Go version being used, see https://bugzilla.redhat.com/show_bug.cgi?id=2037274#c23.

/cc @deads2k @stlaz @mfojtik

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: s-urbaniak
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@s-urbaniak
Copy link
Contributor Author

This has to be backported back to OpenShift 4.10.

@s-urbaniak
Copy link
Contributor Author

closing to avoid backport pain

@s-urbaniak s-urbaniak closed this May 17, 2023
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Jira Issue OCPBUGS-12907. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

This removes the InvalidProviderInvalidCertsUpgradeable condition present in 4.9. This condition is not present in 4.10 any more as the controller setting it is removed.

The underlying reason is that invalid certs were tolerated in 4.9, however in 4.10 they won't work at all any more because of the Go version being used, see https://bugzilla.redhat.com/show_bug.cgi?id=2037274#c23.

/cc @deads2k @stlaz @mfojtik

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants