Skip to content

Conversation

@s-urbaniak
Copy link
Contributor

This removes the InvalidProviderInvalidCertsUpgradeable condition present in 4.9. This condition is not present in 4.10 any more as the controller setting it is removed.

The underlying reason is that invalid certs were tolerated in 4.9, however in 4.10 they won't work at all any more because of the Go version being used, see https://bugzilla.redhat.com/show_bug.cgi?id=2037274#c23.

xref #610

@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label May 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2023

@s-urbaniak: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-12907: pkg/operator/starter: add InvalidProviderInvalidCertsUpgradeable to stale conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2023
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Jira Issue OCPBUGS-12907, which is invalid:

  • expected the bug to target the "4.10.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-12907 to depend on a bug targeting a version in 4.11.0, 4.11.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This removes the InvalidProviderInvalidCertsUpgradeable condition present in 4.9. This condition is not present in 4.10 any more as the controller setting it is removed.

The underlying reason is that invalid certs were tolerated in 4.9, however in 4.10 they won't work at all any more because of the Go version being used, see https://bugzilla.redhat.com/show_bug.cgi?id=2037274#c23.

xref #610

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 17, 2023
@s-urbaniak
Copy link
Contributor Author

/cc @deads2k @stlaz @mfojtik

@openshift-ci openshift-ci bot requested review from deads2k, mfojtik and stlaz May 17, 2023 12:30
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: s-urbaniak
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@s-urbaniak
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Jira Issue OCPBUGS-12907, which is invalid:

  • expected Jira Issue OCPBUGS-12907 to depend on a bug targeting a version in 4.11.0, 4.11.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 17, 2023
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Jira Issue OCPBUGS-12907, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13732 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13732 targets the "4.11.0" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 17, 2023
@openshift-ci openshift-ci bot requested a review from xingxingxia May 17, 2023 12:39
@s-urbaniak
Copy link
Contributor Author

closing out as fixing this can be done manually and the criticality is not high enough.

@s-urbaniak s-urbaniak closed this May 17, 2023
@s-urbaniak s-urbaniak deleted the ocpbugs-12907-4.10 branch May 17, 2023 14:06
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Jira Issue OCPBUGS-12907. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

This removes the InvalidProviderInvalidCertsUpgradeable condition present in 4.9. This condition is not present in 4.10 any more as the controller setting it is removed.

The underlying reason is that invalid certs were tolerated in 4.9, however in 4.10 they won't work at all any more because of the Go version being used, see https://bugzilla.redhat.com/show_bug.cgi?id=2037274#c23.

xref #610

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants