CNTRLPLANE-3237: pick https://github.com/openshift/library-go/pull/2449- #2287

[p0lyn0mial]

Summary by CodeRabbit

• Chores
  • Updated an underlying library dependency to a newer version.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@p0lyn0mial: This pull request references CNTRLPLANE-3237 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c3f8b3ca-3a3a-4957-889a-82bc4ac3bd7d

📥 Commits

Reviewing files that changed from the base of the PR and between 0a2f7eb and f2a8e7d.

⛔ Files ignored due to path filters (9)

• go.sum is excluded by !**/*.sum
• vendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/kms_preflight_controller.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/preflight/always_succeed_deployer.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/preflight/assets/kms-preflight-pod.yaml is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/preflight/cmd.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/preflight/pod_status.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/library-go/pkg/operator/status/status_controller.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/openshift/library-go/test/library/encryption/kms/vault.go is excluded by !**/vendor/**, !vendor/**
• vendor/modules.txt is excluded by !**/vendor/**, !vendor/**

📒 Files selected for processing (1)

• go.mod

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.

---

Walkthrough

The pull request updates the direct github.com/openshift/library-go dependency in go.mod to a newer pseudo-version.

Changes

Library Go dependency update

Layer / File(s)	Summary
Update library-go requirement go.mod	The direct github.com/openshift/library-go requirement changes to v0.0.0-20260904093542-946ee696bcb5.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f2a8e

This updates library-go to a newer pinned pseudo-version. The dependency is checksum-verified with no identified new vulnerability exposure, so the change is ready to merge.

Suggested reviewers: bertinatto, ardaguclu

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies the Jira issue and the specific upstream library-go pull request being picked. This matches the dependency update in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes the library-go dependency, its checksums, vendored library-go code, and KMS test-support code. The parent-to-commit diff adds or changes no Ginkgo title declarations. A …
Test Structure And Quality	✅ Passed	PASS: The pull request does not add or modify any Ginkgo It block, BeforeEach, AfterEach, Eventually, or Consistently call. The only test-related change is in the vendored Vault helper, wher…
Microshift Test Compatibility	✅ Passed	PASS: The pull-request diff adds no Go files and adds no Ginkgo declarations such as It, Describe, Context, or When. The only changed test-related path is an existing vendored Vault helper wit…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS. The pull-request diff adds no new Ginkgo e2e tests. HEAD changes go.mod, go.sum, vendor/modules.txt, and vendored library-go implementation/helper files. No changed file contains new `It()…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request only bumps library-go and updates generated vendor content. No application manifests, operator code, or controllers outside the dependency vendor tree changed. The changed ven…
Ote Binary Stdout Contract	✅ Passed	No OTE stdout-contract failure was introduced. The patch updates library-go metadata and vendored library code; it does not change the OTE entry point or suite setup. The OTE main calls `klog.LogToStd…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request adds no Ginkgo e2e tests or test declarations. The exact commit diff changes go.mod, go.sum, vendor code, and vendor metadata only. The only changed test-area file is a vendored…
No-Weak-Crypto	✅ Passed	PASS: The pull request changes the library-go dependency and its vendored KMS/status files, but the diff adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or non-constant-time secret comparis…
Container-Privileges	✅ Passed	PASS. The pull-request diff adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or security-context setting. The vendored KMS preflight template retains…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The PR updates library-go and its vendored files, but it adds no logging call and does not add any sensitive value to an existing log. The changed Vault test commands only add the fixed namespac…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[gangwgr]

/lgtm

[openshift-merge-bot]

Scheduling required tests:
/test e2e-agnostic
/test e2e-agnostic-upgrade
/test e2e-console-login
/test e2e-gcp-operator-disruptive
/test e2e-oidc
/test e2e-operator

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-operator-encryption-kms
/test e2e-aws-operator-encryption-kms-2
/test e2e-gcp-operator-encryption-perf
/test e2e-gcp-operator-encryption-rotation
/test e2e-operator-encryption

[bertinatto]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bertinatto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[p0lyn0mial]

/retest

[openshift-ci]

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-console-login	f2a8e7d	link	true	/test e2e-console-login
ci/prow/e2e-aws-operator-encryption-kms-2	f2a8e7d	link	false	/test e2e-aws-operator-encryption-kms-2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.