OCPBUGS-84519: Add terminationMessagePolicy to missing ovn-kubernetes containers

[jluhrsen]

Sets FallbackToLogsOnError on error-cni-init and ovnkube-upgrades-prepuller containers.

All other containers in openshift-ovn-kubernetes namespace already have this field set.

Fixes: https://issues.redhat.com/browse/OCPBUGS-84519

Summary by CodeRabbit

• Chores
  • Enhanced error diagnostic capabilities for OVN-Kubernetes network components by updating how container termination messages are handled. These configuration changes ensure that error information is properly captured and available in logs when components terminate unexpectedly or during normal operations and system upgrades, improving visibility for troubleshooting and incident response.

[coderabbitai]

Walkthrough

Two OVN-Kubernetes DaemonSet manifests are updated to add terminationMessagePolicy: FallbackToLogsOnError to container specifications, ensuring termination messages fall back to pod logs when unavailable.

Changes

Manifest Configuration Updates

Layer / File(s)	Summary
Termination Message Policy bindata/network/ovn-kubernetes/common/error-cni.yaml, bindata/network/ovn-kubernetes/common/pre-puller.yaml	terminationMessagePolicy: FallbackToLogsOnError added to error-cni-init and ovnkube-upgrades-prepuller container specs respectively.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR modifies only YAML manifest files (error-cni.yaml and pre-puller.yaml), not test code. The check for stable test names does not apply to YAML configuration files.
Test Structure And Quality	✅ Passed	Not applicable. PR only modifies YAML manifests, no Ginkgo test code to review. The custom check requires reviewing test code quality, which is absent.
Microshift Test Compatibility	✅ Passed	PR adds no Ginkgo e2e tests. Only Kubernetes manifest YAML files were modified (error-cni.yaml, pre-puller.yaml). The MicroShift compatibility check is not applicable to manifest-only changes.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add any Ginkgo e2e tests. It only modifies Kubernetes YAML manifest files to add terminationMessagePolicy fields. The SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only adds terminationMessagePolicy field to containers. This controls error message capture at termination and has no impact on scheduling or topology constraints.
Ote Binary Stdout Contract	✅ Passed	PR only modifies YAML manifest files, not binary code. OTE Binary Stdout Contract checks process-level code; this PR has no code changes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies only YAML manifest files (error-cni.yaml and pre-puller.yaml), not Ginkgo e2e tests. The custom check only applies to new Ginkgo e2e tests, so it is not applicable here.
Title check	✅ Passed	The PR title accurately describes the main change: adding terminationMessagePolicy to two missing ovn-kubernetes containers (error-cni-init and ovnkube-upgrades-prepuller), directly matching the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen
Once this PR has been reviewed and has the lgtm label, please assign jcaamano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jluhrsen]

/retest

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-84519, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Sets FallbackToLogsOnError on error-cni-init and ovnkube-upgrades-prepuller containers.

All other containers in openshift-ovn-kubernetes namespace already have this field set.

Fixes: https://issues.redhat.com/browse/OCPBUGS-84519

Summary by CodeRabbit

• Chores
• Enhanced error diagnostic capabilities for OVN-Kubernetes network components by updating how container termination messages are handled. These configuration changes ensure that error information is properly captured and available in logs when components terminate unexpectedly or during normal operations and system upgrades, improving visibility for troubleshooting and incident response.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jluhrsen]

/testwith openshift/origin/main/e2e-aws-ovn openshift/origin#31159

[jluhrsen]

/jira refresh

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-84519, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jluhrsen: This PR was included in a payload test run from openshift/origin#31159
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[openshift-ci]

@jluhrsen: This PR was included in a payload test run from openshift/origin#31159
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[openshift-ci]

@jluhrsen: This PR was included in a payload test run from openshift/origin#31159
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[jluhrsen]

/payload-job periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

[openshift-ci]

@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a92320e0-4dbf-11f1-8bea-557ac868de2e-0

[jluhrsen]

/payload-job-with-prs periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn #3004

[openshift-ci]

@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bb91c1a0-4dbf-11f1-9b7b-9d0ccc30a850-0

[openshift-ci]

@jluhrsen: This PR was included in a payload test run from #3004
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bb91c1a0-4dbf-11f1-9b7b-9d0ccc30a850-0

[openshift-ci]

@jluhrsen: This PR was included in a payload test run from openshift/origin#31159
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/38cd1520-4dc0-11f1-88e1-de05fbb40dcf-0

[jluhrsen]

/retest

[openshift-ci]

@jluhrsen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	aef9a47	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.