OCPBUGS-84519: Remove openshift-ovn-kubernetes terminationMessagePolicy exemption

[jluhrsen]

Containers in openshift-ovn-kubernetes namespace now have terminationMessagePolicy set, exemption no longer needed.

Depends on: openshift/cluster-network-operator#3004

Fixes: https://issues.redhat.com/browse/OCPBUGS-84519

Summary by CodeRabbit

• Bug Fixes
  • Removed an outdated exemption from the policy enforcement list, enabling stricter validation of container termination message handling across all cluster components. This change ensures consistent policy compliance without legacy exceptions.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

Walkthrough

The existingViolations grandfathering list in the cluster version operator's termination message policy monitor test was updated by removing an entry that previously exempted the pods/ovnkube-upgrades-prepuller resource in the openshift-ovn-kubernetes namespace from the terminationMessagePolicy=FallbackToLogsOnError enforcement check.

Changes

Cohort / File(s)	Summary
Termination Message Policy Exemptions pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go	Removed openshift-ovn-kubernetes namespace entry from the existingViolations grandfathering list, eliminating a pre-enforcement exception for pods/ovnkube-upgrades-prepuller.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR modifies only a monitor test file with no Ginkgo test declarations. The custom check applies to Ginkgo tests (It(), Describe(), Context(), When()), which are not present in this PR's changes.
Test Structure And Quality	✅ Passed	The PR changes a MonitorTest analyzer, not Ginkgo test code. The custom check applies only to Ginkgo tests, making it inapplicable here.
Microshift Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests. It only modifies a monitor test data structure. MicroShift check applies only to new Ginkgo tests.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The custom check applies only to new Ginkgo e2e tests. This PR modifies a monitor test file by removing one exemption entry. No Ginkgo tests are added, so the check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only test/monitoring file, removing a test exemption. Does not introduce scheduling constraints or modify operator code. Check does not apply to test-only changes.
Ote Binary Stdout Contract	✅ Passed	The PR removes an entry from the existingViolations map in monitortest.go. No process-level stdout writes found. All fmt usage is for string building, not stdout output.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Check not applicable. PR modifies monitor test infrastructure (MonitorTest interface implementation), not new Ginkgo e2e tests. No It()/Describe()/Context()/When() test declarations present.
Title check	✅ Passed	The title accurately summarizes the main change: removing a terminationMessagePolicy exemption for the openshift-ovn-kubernetes namespace, which directly corresponds to the single file modification.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@jluhrsen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	8b683dc	link	true	/test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jluhrsen]

/testwith openshift/origin/main/e2e-aws-ovn openshift/cluster-network-operator#3004

[jluhrsen]

/lgtm

[openshift-ci]

@jluhrsen: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jluhrsen]

/test e2e-aws-ovn

[jluhrsen]

/testwith openshift/origin/main/e2e-aws-ovn openshift/cluster-network-operator#3004

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-84519, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Containers in openshift-ovn-kubernetes namespace now have terminationMessagePolicy set, exemption no longer needed.

Depends on: openshift/cluster-network-operator#3004

Fixes: https://issues.redhat.com/browse/OCPBUGS-84519

Summary by CodeRabbit

• Bug Fixes
• Removed an outdated exemption from the policy enforcement list, enabling stricter validation of container termination message handling across all cluster components. This change ensures consistent policy compliance without legacy exceptions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jluhrsen]

/jira refresh

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-84519, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jluhrsen]

/payload-job-with-prs periodic-ci-openshift-release-master-ci-5.0-e2e-aws openshift/cluster-network-operator#3004

[openshift-ci]

@jluhrsen: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[jluhrsen]

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-5.0-e2e-aws openshift/cluster-network-operator#3004

[openshift-ci]

@jluhrsen: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[jluhrsen]

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn openshift/cluster-network-operator#3004

[openshift-ci]

@jluhrsen: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[jluhrsen]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn

[openshift-ci]

@jluhrsen: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[jluhrsen]

/payload-job periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

[openshift-ci]

@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2d65ec70-4dc0-11f1-9b2f-aca598ee8b64-0

[jluhrsen]

/payload-job-with-prs periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn openshift/cluster-network-operator#3004

[openshift-ci]

@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/38cd1520-4dc0-11f1-88e1-de05fbb40dcf-0

[sosiouxme]

/lgtm
/hold
for openshift/cluster-network-operator#3004 to go in first

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jluhrsen, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sosiouxme]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jluhrsen]

@sosiouxme , do you know how this should work? I had assumed this PR would produce a failure in this presubmit I triggered here (e2e-aws-ovn), but it didn't. the network-operator check for termination policy passes.