Skip to content

"BEGIN PGP ARMORED FILE" -> "BEGIN PGP PUBLIC KEY BLOCK" for Go #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2019
Merged

"BEGIN PGP ARMORED FILE" -> "BEGIN PGP PUBLIC KEY BLOCK" for Go #15

merged 1 commit into from
Jun 18, 2019

Conversation

@wking
Copy link
Member

@wking wking commented May 31, 2019

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 31, 2019
@cgwalters
Copy link
Member

cgwalters commented May 31, 2019

Why aren't we using the support for multiple keys in the ConfigMap to have them distinct there rather than the ad-hoc concatenation?

@wking
Copy link
Member Author

wking commented May 31, 2019

Why aren't we using the support for multiple keys in the ConfigMap to have them distinct there rather than the ad-hoc concatenation?

Does the CVO already support that?

@smarterclayton
Copy link
Contributor

smarterclayton commented May 31, 2019

Multiple keys in configmap is an AND. Multiple keys in a keyring is an OR.

Beta2 and gold key are an OR until we get rid of beta2 key.

eparis
eparis reviewed May 31, 2019
View reviewed changes
@wking wking force-pushed the headers-go-likes-for-multi-key-keyring branch from 55054e6 to eab0d87 Compare May 31, 2019 15:26
@eparis
Copy link
Member

eparis commented May 31, 2019

/retest

@eparis
Copy link
Member

eparis commented Jun 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2019
@eparis eparis mentioned this pull request Jun 18, 2019
Merged
@abhinavdahiya
Copy link

abhinavdahiya commented Jun 18, 2019

/approve

@eparis eparis added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: abhinavdahiya, eparis, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cca4ce6 into openshift:master Jun 18, 2019
@wking wking deleted the headers-go-likes-for-multi-key-keyring branch September 5, 2019 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@eparis eparis eparis left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@eparis eparis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wking @cgwalters @smarterclayton @eparis @abhinavdahiya @openshift-ci-robot @openshift-merge-robot