EXPERIMENT: Revert "OTA-2084: Conditionally deploy console plugin when AgenticRun CRD is present" - #1435
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@redhat-chai-bot: This pull request references OTA-2084 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughThe change adds release and capability annotations to console plugin manifests, renames the plugin service identity, templates its deployment image, removes console-plugin orchestration from AgenticRun reconciliation, and gates AgenticRun controller startup and queueing on ChangesAgenticRun and console plugin integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Operator
participant FeatureSetCheck
participant AgenticRunController
Operator->>FeatureSetCheck: evaluate requiredFeatureSet
FeatureSetCheck-->>Operator: enable only for TechPreviewNoUpgrade
Operator->>AgenticRunController: start worker when enabled
Operator->>AgenticRunController: enqueue available-update or status-pruning sync
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/payload 5.0 nightly blocking e2e-aws-ovn-upgrade-single-node |
|
@redhat-chai-bot: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-aws-upgrade-ovn-single-node 10 |
|
@smg247: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/02316420-8a89-11f1-9951-2ac80d187a2b-0 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pkg/cvo/cvo.go (1)
1222-1226: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd coverage for both controller-gate outcomes.
This helper controls startup and both enqueue paths. Add tests for
TechPreviewNoUpgradeand disabled sets such asDefaultandDevPreviewNoUpgrade, including assertions that no AgenticRun work is queued when disabled.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/cvo/cvo.go` around lines 1222 - 1226, Add tests for Operator.shouldEnableAgenticRunController covering TechPreviewNoUpgrade as enabled and Default and DevPreviewNoUpgrade as disabled. Verify the disabled cases also prevent AgenticRun work from being queued through both enqueue paths that depend on this gate.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@pkg/cvo/cvo.go`:
- Around line 1222-1226: Add tests for Operator.shouldEnableAgenticRunController
covering TechPreviewNoUpgrade as enabled and Default and DevPreviewNoUpgrade as
disabled. Verify the disabled cases also prevent AgenticRun work from being
queued through both enqueue paths that depend on this gate.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 28a718c6-7faf-4a31-9d97-b3e05a7fd555
📒 Files selected for processing (17)
install/0000_50_cluster-update-console-plugin_10_namespace.yamlinstall/0000_50_cluster-update-console-plugin_15_serviceaccount.yamlinstall/0000_50_cluster-update-console-plugin_20_networkpolicy.yamlinstall/0000_50_cluster-update-console-plugin_30_configmap.yamlinstall/0000_50_cluster-update-console-plugin_50_deployment.yamlinstall/0000_50_cluster-update-console-plugin_60_service.yamlinstall/0000_50_cluster-update-console-plugin_90_consoleplugin.yamlpkg/agenticrun/bindata/assets.gopkg/agenticrun/bindata/assets/networkpolicy-allow-console.yamlpkg/agenticrun/consoleplugin.gopkg/agenticrun/controller.gopkg/agenticrun/controller_test.gopkg/cvo/availableupdates.gopkg/cvo/availableupdates_test.gopkg/cvo/cvo.gopkg/cvo/status.gopkg/payload/render_test.go
💤 Files with no reviewable changes (6)
- pkg/agenticrun/bindata/assets/networkpolicy-allow-console.yaml
- pkg/agenticrun/consoleplugin.go
- pkg/agenticrun/bindata/assets.go
- pkg/cvo/availableupdates_test.go
- pkg/agenticrun/controller.go
- pkg/agenticrun/controller_test.go
|
/payload-aggregate-with-prs periodic-ci-openshift-release-main-ci-5.0-e2e-aws-upgrade-ovn-single-node 10 openshift/console-operator#1200 |
|
@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f0afade0-8aa8-11f1-8113-af31792b0819-0 |
|
/close |
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@smg247: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Summary
This is an experimental revert to test a hypothesis — do not merge.
Reverts PR #1425 (merge commit 027e419) to test whether the agenticrun controller running unconditionally is causing the SNO upgrade pathological events failure in the 5.0 nightly stream.
Context
The 5.0 amd64 nightly stream has been rejected for 3 consecutive payloads. The sole blocking failure is
periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-upgrade-single-node-aggregated.The root cause is the pathological events monitor test detecting
machine-api's clusteroperator emitting 25 "Status upgrade Progressing" k8s events during SNO micro upgrades (threshold is 20). This test first started failing consistently (9/10 runs) in payload5.0.0-0.nightly-2026-07-27-110939.Why PR #1425 is suspected
PR #1425 removed the
shouldEnableAgenticRunController()guard that previously gated the agenticrun controller behindTechPreviewNoUpgrade. After this change, the controller runs on all clusters, adding:On SNO, where all control plane workloads share a single node, this extra API server activity during upgrade likely increases the rate at which
machine-api's status condition toggles, pushing the k8s event count from below 20 to 25. No other component PR correlates with the failure window. Upgrade timing data confirms the upgrade itself is not slower — the event emission rate increased, not the duration.Test plan
Run
/payloadfor the failing SNO upgrade job against this revert PR:Revert details
027e419696ec443ee8b6257bc306d14dd024eaa7(-m 1, mainline parent55dfed31)02387cdc95d6efac314af425da728fc5d3b66295This reverts commit 027e419.
@smg247 requested via Chai Bot
Summary by CodeRabbit
New Features
Behavior Changes