[release-4.21] OCPBUGS-100111: Sort plugin list to make them deterministic - #1203
Conversation
Removed unused import for retry utility.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/retitle [release-4.21] OCPBUGS-100111: Sort plugin list to make them deterministic |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-100111, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-100387 has been cloned as Jira Issue OCPBUGS-104516. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-104516, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle [release-4.21] OCPBUGS-100111: Sort plugin list to make them deterministic |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-100111, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@logonoff: This pull request references Jira Issue OCPBUGS-100111, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@TheRealJon , do you mind pushing this commit to this PR branch? commit e99b6ee59b2472bfa837ea73103cc7ad0b5f8061 (pr/1203)
gpg: Signature made Tue 4 Aug 09:20:18 2026 EDT
gpg: using DSA key BE0A9327AA0793A1DD56DE14725569FB646A4BFD
gpg: issuer "git@logonoff.co"
gpg: Good signature from "logonoff <git@logonoff.co>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the owner.
Primary key fingerprint: 438B 252A 8EEC CDF7 B700 7C2B 6DAC 5A6D CD9E 7E97
Subkey fingerprint: BE0A 9327 AA07 93A1 DD56 DE14 7255 69FB 646A 4BFD
Author: logonoff <git@logonoff.co>
Date: Tue Aug 4 09:20:18 2026 -0400
Revert "Remove unused import for k8s client-go retry"
This reverts commit 637d951888bab8f005628393e248521c1e261f9b.
diff --git a/pkg/console/operator/sync_v400.go b/pkg/console/operator/sync_v400.go
index 8ce4aea60..69d93e929 100644
--- a/pkg/console/operator/sync_v400.go
+++ b/pkg/console/operator/sync_v400.go
@@ -18,6 +18,7 @@ import (
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/util/sets"
+ "k8s.io/client-go/util/retry"
"k8s.io/klog/v2"
// openshift |
|
@logonoff done 🫡 |
|
/label backport-risk-assessed |
|
/verified by CI |
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@logonoff: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label backport-risk-assessed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, openshift-cherrypick-robot, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f730484
into
openshift:release-4.21
|
@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-100111 Jira Issue OCPBUGS-100111 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is an automated cherry-pick of #1165
/assign logonoff